FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Correct TabView icon rendering mode by rclai · Pull Request #1149 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Correct TabView icon rendering mode - #1149

Merged
hshristov merged 2 commits into
NativeScript:masterfrom
rclai:patch-1
Nov 30, 2015
ConversationCommits (2)ChecksFiles changed
Merged

Correct TabView icon rendering mode#1149
hshristov merged 2 commits into
NativeScript:masterfrom
rclai:patch-1

Conversation

rclai commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

Fixes #1148.

ns-bot commented Nov 24, 2015

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot added cla: yes and removed cla: no labels Nov 24, 2015

rclai commented Nov 25, 2015

Copy link
Copy Markdown
Contributor Author

@enchev, is there something I need to do about the failed test of @ns-bot? I can't see the details.

enchev commented Nov 25, 2015

Copy link
Copy Markdown
Contributor

Hey @rclai,

We have a problem with random failing tests for Android. No need to do anything extra.

ns-bot commented Nov 25, 2015

Copy link
Copy Markdown

Test PASSed.

ErjanGavalji commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

👍

1 similar comment

hshristov commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

👍

hshristov added this to the 1.5.1 milestone Nov 30, 2015

vakrilov commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

👍

hshristov added ready for test TSC needs to test this and confirm against live production apps and automated test suites bug severity: low os: ios labels Nov 30, 2015
hshristov pushed a commit that referenced this pull request Nov 30, 2015
Merge pull request #1149 from rclai/patch-1
72577a8 
Correct TabView icon rendering mode
hshristov merged commit 72577a8 into NativeScript:master Nov 30, 2015
tjvantoll mentioned this pull request Jul 11, 2016
Merged

lock Bot commented Aug 29, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug cla: yes os: ios ready for test TSC needs to test this and confirm against live production apps and automated test suites severity: low

Projects

None yet

Milestone

1.5.1

Development

Successfully merging this pull request may close these issues.

iOS TabView Icon rendering mode set wrong

6 participants

Back | FazBrowse Home | New Git URL