Repository navigation
perf(ios): request layout once per turn and append subviews without copying - #11507
Merged
NathanWalker merged 2 commits intoOct 6, 2026
Merged
NathanWalker merged 2 commits into
NathanWalker merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Oct 6, 2026
Copy link
Copy Markdown
|
View your CI Pipeline Execution ↗ for commit 3d0b554
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at 2026-10-06 23:01:25 UTC |
Sorry, something went wrong.
Copy link
Copy Markdown
npm i https://pkg.pr.new/@nativescript/core@11507 npm i https://pkg.pr.new/@nativescript/vite@11507 npm i https://pkg.pr.new/@nativescript/webpack@11507 commit: 3d0b554 |
Sorry, something went wrong.
farfromrefug
requested changes
Oct 6, 2026
Comment thread
packages/core/ui/text-base/index.ios.ts
Outdated
…opying - requestLayout returns early when the view already climbed in this turn and is still flagged. CSS calls it once per layout-affecting property, so each call climbed to the root with a native setNeedsLayout at every level. A layout pass in between clears the flag, so the next request climbs again; the set is cleared by a microtask. - insertNativeSubview calls addSubview without reading `subviews` when no index is given. Reading it copies the array, so appending k children was O(k^2).
triniwiz
force-pushed
the
perf/ios-view-attach
branch
from
c3fbe9f to
4fd7ff1
Compare
October 6, 2026 20:27
3 of 5 tasks
A synchronous layout pass (e.g. layoutIfNeeded) can lay out an ancestor and clear its flag while skipping a collapsed child, which stays flagged. The child's next requestLayout in the same turn was skipped, so the ancestor never re-laid out and the child stayed hidden after becoming visible. The shortcut now applies only while every ancestor is still flagged.
NathanWalker
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
New specs: a repeat request in the same turn does not climb (fails on main), and a request climbs again in the next turn and after a layout pass.
Numbers
How this was measured
xplat-benchmarks ns-core app (plain core, no plugins), iPhone 17 Pro Max simulator, iOS 26.4. Each scenario mounts about 1,000 views at size M. Base and change were installed alternately for 3 rounds of 10 measured iterations, median ms, lower is better. "Attach" is assigning the built tree to a loaded parent (native view creation, CSS, native setters); "painted" ends one frame after layout. A GC is forced before each mutation, as it already is after each unmount, so a collection pause lands in the same phase for both builds.
Part of a series: #11505, #11506, #11507 (this), #11510.