Repository navigation
fix(ios): TabView search tab placement on iOS 27 - #11509
Merged
NathanWalker merged 1 commit intoOct 6, 2026
Merged
NathanWalker merged 1 commit into
NathanWalker merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
| Command | Status | Duration | Result |
|---|---|---|---|
| nx test apps-automated -c=android | ❌ Failed | 3m 21s | View ↗ |
| nx run-many --target=test --configuration=ci --... | ✅ Succeeded | <1s | View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-10-06 20:32:15 UTC
Sorry, something went wrong.
On iOS 27, assigning viewControllers after tabs replaces the UITab configuration, so the UISearchTab was rendered as a regular inline tab. iOS 27 also only separates a search tab by default when automaticallyActivatesSearch is enabled. On iOS 27+ the tab bar is now configured through tabs alone, the search tab is marked via prominentTabIdentifier, and selection is synced through the UITab delegate callbacks. Adds role="prominent" (SwiftUI's TabRole.prominent) for any tab. iOS 18-26 behavior is unchanged.
NathanWalker
force-pushed
the
fix/ios-27-search-tab
branch
from
11d3f70 to
5b8829c
Compare
October 6, 2026 20:25
Copy link
Copy Markdown
npm i https://pkg.pr.new/@nativescript/core@11509 npm i https://pkg.pr.new/@nativescript/vite@11509 npm i https://pkg.pr.new/@nativescript/webpack@11509 commit: 5b8829c |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On iOS 27, a TabViewItem with role="search" renders as a regular inline tab instead of the separate, floating search button seen on iOS 26.
There are two causes:
What is the new behavior?
On iOS 27+:
On iOS 18–26 the code path is unchanged: the tab delegate methods return early whenever viewControllers is set. On those versions role="prominent" is a regular tab.
Verification
Run on simulators (toolbox + apps/automated):
New e2e tests in TAB-VIEW assert prominentTabIdentifier for the search role, for prominent-over-search precedence, and for no role (they skip below iOS 27). getNativeTabCount falls back to tabs when viewControllers is nil. Core unit tests: 524 passed. Also type-checked against the published @nativescript/types-ios@9.1.3 / @nativescript/types@9.1.3 (identical to the merged #11508 typings).