FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

1631|fix(dialogs): change alert dialog context by ofirdagan · Pull Request #1632 · NativeScript/NativeScript · GitHub

/ NativeScript Public

1631|fix(dialogs): change alert dialog context - #1632

Merged
enchev merged 1 commit into
NativeScript:masterfrom
ofirdagan:master
Feb 24, 2016
ConversationCommits (1)ChecksFiles changed
Merged

1631|fix(dialogs): change alert dialog context#1632
enchev merged 1 commit into
NativeScript:masterfrom
ofirdagan:master

Conversation

ofirdagan commented Feb 24, 2016

Copy link
Copy Markdown
Contributor

closes #1631

ns-bot commented Feb 24, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Feb 24, 2016

Copy link
Copy Markdown

Please sign CLA at http://www.nativescript.org/cla

ns-bot added cla: no and removed cla: yes labels Feb 24, 2016

dtopuzov commented Feb 24, 2016

Copy link
Copy Markdown
Contributor

run ci

ns-bot commented Feb 24, 2016

Copy link
Copy Markdown

CLA signature found, happy contributing!

ns-bot added cla: yes and removed cla: no labels Feb 24, 2016

enchev commented Feb 24, 2016

Copy link
Copy Markdown
Contributor

👍

enchev pushed a commit that referenced this pull request Feb 24, 2016
Merge pull request #1632 from ofirdagan/master
52c8e53 
1631|fix(dialogs): change alert dialog context
enchev merged commit 52c8e53 into NativeScript:master Feb 24, 2016

NathanWalker commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

I am still seeing this issue on Android:

JS: Error: Uncaught (in promise): Error: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources$Theme android.content.Context.getTheme()' on a null object reference
JS: android.app.AlertDialog.resolveDialogTheme(AlertDialog.java:154)
JS: android.app.AlertDialog$Builder.(AlertDialog.java:379)
JS: com.tns.Runtime.callJSMethodNative(Native Method)

By just simply calling dialogs.action or dialogs.prompt. Any idea on how to fix this issue?

NathanWalker mentioned this pull request Sep 1, 2016
Closed

lock Bot commented Aug 28, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dialogs.confirm throws exception when writing angular 2 + {N} app

6 participants

Back | FazBrowse Home | New Git URL