Allow multiple headers with the same name to be retrieved from a HTTP response - #1707
Merged
enchev merged 1 commit intoMar 8, 2016
Merged
enchev merged 1 commit into
enchev merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
apps/tests/http-tests.ts
Outdated
| (<any>http).addHeader(headers, "key", "value2"); | ||
|
|
||
| try { | ||
| TKUnit.assert(Array.isArray(headers["key"]), "Headers with same key not added properly!"); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why not check for both values here instead of just verifying the result as being an array?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
👍 |
Sorry, something went wrong.
enchev
pushed a commit
that referenced
this pull request
Mar 8, 2016
Allow multiple headers with the same name to be retrieved from a HTTP response
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #1695