FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure parent directory when creating a new file by mbektchiev · Pull Request #1888 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Ensure parent directory when creating a new file - #1888

Merged
enchev merged 1 commit into
masterfrom
bektchiev/fix-create-file
Apr 14, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Ensure parent directory when creating a new file#1888
enchev merged 1 commit into
masterfrom
bektchiev/fix-create-file

Conversation

mbektchiev commented Apr 5, 2016

Copy link
Copy Markdown
Contributor

createNewFile throws an exception if the parent directory doesn't exist

Fixes #1887

ns-bot commented Apr 5, 2016

Copy link
Copy Markdown

Please sign CLA at http://www.nativescript.org/cla

ns-bot added cla: no and removed cla: yes labels Apr 5, 2016

atanasovg commented Apr 7, 2016

Copy link
Copy Markdown
Contributor

👍

hshristov commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

👍 after adding test @mbektchiev

enchev commented Apr 11, 2016

Copy link
Copy Markdown
Contributor

Hey @mbektchiev,

Please sign our CLA and add small test here.

Thanks

mbektchiev force-pushed the bektchiev/fix-create-file branch from 2e5a2b4 to 13cc476 Compare April 12, 2016 09:30

mbektchiev commented Apr 12, 2016

Copy link
Copy Markdown
Contributor Author

Done.

ns-bot commented Apr 12, 2016

Copy link
Copy Markdown

CLA signature found, happy contributing!

ns-bot added cla: yes and removed cla: no labels Apr 12, 2016
mbektchiev force-pushed the bektchiev/fix-create-file branch from 13cc476 to 1275b8c Compare April 12, 2016 14:24
enchev closed this Apr 13, 2016
enchev reopened this Apr 13, 2016

dtopuzov commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

run ci

1 similar comment

dtopuzov commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

run ci

Ensure parent directory when creating a new file
dcdd0a6 
createNewFile throws an exception if the parent directory doesn't exist
mbektchiev force-pushed the bektchiev/fix-create-file branch from 1275b8c to dcdd0a6 Compare April 14, 2016 11:27
enchev merged commit d88e675 into master Apr 14, 2016
enchev deleted the bektchiev/fix-create-file branch April 14, 2016 12:35

lock Bot commented Aug 28, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parent directory not created by file-system.File.fromPath()

6 participants

Back | FazBrowse Home | New Git URL