FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Manually applying CSS is removed and now it is done once per cell. by hshristov · Pull Request #2174 · NativeScript/NativeScript · GitHub

Manually applying CSS is removed and now it is done once per cell. - #2174

Merged
hshristov merged 2 commits into
masterfrom
hhristov/list-view-optimization
May 25, 2016
Merged

hshristov merged 2 commits into
masterfrom
hhristov/list-view-optimization

Conversation

Copy link
Copy Markdown
Contributor

Clear bindingContext is now done in refresh method instead of preparing cell.
Added test for nulling cells bindingContext.
Obsoleted isScrolling property on ListView.
Removed android scroll listener.
Uncommented few tests and made them work.
Fixed android ListView eachChildView to return the wrapping StackLayout so that Unloading now works as expected.
onUnload method in view-common now raise unloaded only if item isLoaded=true.

Clearing bindingContext is now done in refresh method instead of preparing cell.
Obsolete isScrolling property on ListView.
Removed android scroll listener.
Added test for nulling cells bindingContext.
Uncommented few tests and made them work.
Fixed android ListView eachChildView to return the wrapping StackLayout so that Unloading now works as expected.
onUnload method in view-common now raise unloaded only if item isLoaded=true.
ns-bot added cla: yes and removed cla: no labels May 25, 2016
hshristov merged commit b0cff20 into master May 25, 2016
hshristov deleted the hhristov/list-view-optimization branch May 25, 2016 11:03
hshristov changed the title Manually applying CSS in removed and now it is done once per cell. Manually applying CSS is removed and now it is done once per cell. Jul 1, 2016
hshristov added this to the 2.1 milestone Jul 1, 2016
hshristov self-assigned this Jul 1, 2016

lock Bot commented Aug 28, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL