Image should not requestLayout when measured with 'exactly' spec - #2198
Merged
PanayotCankov merged 1 commit intoMay 30, 2016
Merged
PanayotCankov merged 1 commit into
PanayotCankov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Image should not requestLayout when sized with 'exactly' spec Update image tests Tests will run in ios only
PanayotCankov
force-pushed
the
cankov/image-exactly
branch
from
28a6ab5 to
717b513
Compare
May 27, 2016 13:58
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will improve the performance in cases when the Image src is set on image that is in GridLayout with start row and column. The layout won't be invalidated.
Added a few npm scripts that:
Do tns-core-modules$ npm link and tests$ npm link tns-core-modules:
So you can easily run the tests.
Do a tsc using the locally installed typescript compiler:
Transpile TS files to JS files and watch TS for changes. The transpiling does not type-check so it is fast but make sure to call npm run tsc before commit to do full TypeScript compilation: