Fixed animation value sync issues - #2266
Merged
tzraikov merged 1 commit intoJun 17, 2016
Merged
tzraikov merged 1 commit into
tzraikov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
👍 |
Sorry, something went wrong.
tzraikov
force-pushed
the
raikov/fix-animationsync
branch
3 times, most recently
from
2275d3d to
a03baf0
Compare
June 9, 2016 13:40
Comment thread
tns-core-modules/ui/animation/keyframe-animation.ts
| this._reject(new Error("Animation cancelled.")); | ||
| } | ||
|
|
||
| private _resetAnimationValues(view: view.View, animation: Object) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why do we need to reset animation values?
Sorry, something went wrong.
tzraikov
force-pushed
the
raikov/fix-animationsync
branch
2 times, most recently
from
f15f86a to
9566ecb
Compare
June 13, 2016 16:12
tzraikov
force-pushed
the
raikov/fix-animationsync
branch
from
79c2fb9 to
d810a77
Compare
June 14, 2016 08:31
Copy link
Copy Markdown
Contributor
|
👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
run ci |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following scenario (existing in iOS):