FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix: Multiple ScrollViews on one page fires scrollEvent simultaneously by hamorphis · Pull Request #2412 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Fix: Multiple ScrollViews on one page fires scrollEvent simultaneously #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamorphis merged 1 commit into from
Jul 4, 2016
Conversation 4 Commits 1 Checks 0 Files changed
Merged

Fix: Multiple ScrollViews on one page fires scrollEvent simultaneously #2412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
33 changes: 24 additions & 9 deletions tns-core-modules/ui/scroll-view/scroll-view.android.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export class ScrollView extends common.ScrollView implements definition.ScrollVi
private _android: org.nativescript.widgets.VerticalScrollView | org.nativescript.widgets.HorizontalScrollView;
private _androidViewId: number = -1;
private handler: android.view.ViewTreeObserver.OnScrollChangedListener;

get android(): android.view.ViewGroup {
return this._android;
}
Expand Down Expand Up @@ -111,20 +110,36 @@ export class ScrollView extends common.ScrollView implements definition.ScrollVi
var that = new WeakRef(this);
this.handler = new android.view.ViewTreeObserver.OnScrollChangedListener({
onScrollChanged: function () {
var rootScrollView = that.get();
if (rootScrollView && rootScrollView.android) {
rootScrollView.notify(<definition.ScrollEventData>{
object: rootScrollView,
eventName: ScrollView.scrollEvent,
scrollX: rootScrollView.android.getScrollX() / utils.layout.getDisplayDensity(),
scrollY: rootScrollView.android.getScrollY() / utils.layout.getDisplayDensity()
});
var owner: ScrollView = that.get();
if (owner){
owner._onScrollChanged();
}
}
});

this._android.getViewTreeObserver().addOnScrollChangedListener(this.handler);
}

private _lastScrollX: number = -1;
private _lastScrollY: number = -1;
private _onScrollChanged(){
if (this.android) {
// Event is only raised if the scroll values differ from the last time in order to wokraround a native Android bug.
// https://github.com/NativeScript/NativeScript/issues/2362
let newScrollX = this.android.getScrollX();
let newScrollY = this.android.getScrollY();
if (newScrollX !== this._lastScrollX || newScrollY !== this._lastScrollY){
this.notify(<definition.ScrollEventData>{
object: this,
eventName: ScrollView.scrollEvent,
scrollX: newScrollX / utils.layout.getDisplayDensity(),
scrollY: newScrollY / utils.layout.getDisplayDensity()
});
this._lastScrollX = newScrollX;
this._lastScrollY = newScrollY;
}
}
}

protected dettachNative() {
this._android.getViewTreeObserver().removeOnScrollChangedListener(this.handler);
Expand Down
Back | FazBrowse Home | New Git URL