FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

hhristov/recycle native view android by hshristov · Pull Request #3885 · NativeScript/NativeScript · GitHub

/ NativeScript Public

hhristov/recycle native view android - #3885

Merged
vchimev merged 4 commits into
masterfrom
hhristov/recycle-native-view-android
Mar 28, 2017
ConversationCommits (4)ChecksFiles changed
Merged

hhristov/recycle native view android#3885
vchimev merged 4 commits into
masterfrom
hhristov/recycle-native-view-android

Conversation

hshristov commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Rename:
_createNativeView to createNativeView;
_initNativeView to initNativeView
_disposeNativeView to disposeNativeView
_resetNativeView to resetNativeView

vakrilov approved these changes Mar 28, 2017
View reviewed changes
Comment thread tns-core-modules/ui/core/view-base/view-base.ts Outdated
this.nativeView = this._iosView = (<any>this)._nativeView;
this.createNativeView();
if (!currentNativeView) {
console.log(`${this.typeName} doesnt have NativeView !!!!! =================`);

vakrilov Mar 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

console.log

Comment thread tns-core-modules/ui/date-picker/date-picker.android.ts

[maxDateProperty.getDefault](): Date {
return this.android.getMaxDate();
return this.nativeView.getMaxDate();

vakrilov Mar 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Return type should be number

Comment thread tns-core-modules/ui/date-picker/date-picker.android.ts Outdated
return this.android.getMaxDate();
return this.nativeView.getMaxDate();
}
[maxDateProperty.setNative](value: Date) {

vakrilov Mar 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

value type should be Date | number

Comment thread tns-core-modules/ui/date-picker/date-picker.android.ts

[minDateProperty.getDefault](): Date {
return this.android.getMinDate();
return this.nativeView.getMinDate();

vakrilov Mar 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Return type should be number

Comment thread tns-core-modules/ui/editable-text-base/editable-text-base.android.ts Outdated
(<any>this.nativeView).listener.owner = null;
}

// public _resetNativeView(force?: boolean) {

vakrilov Mar 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

delete?

Comment thread tns-core-modules/ui/html-view/html-view.ios.ts Outdated

public onMeasure(widthMeasureSpec: number, heightMeasureSpec: number): void {
var nativeView = this._nativeView;
var nativeView = this._ios;

vakrilov Mar 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this.nativeView

Comment thread tns-core-modules/ui/time-picker/time-picker.android.ts Outdated
}

const validTime = getValidTime(timePicker, hour, minute);
hourProperty.nativeValueChange(timePicker, validTime.hour);

vakrilov Mar 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

delete those - not needed

Hristo Hristov added 4 commits March 28, 2017 18:08
NativeView recycled for android
f2898f8
rename:
c18a76c 
_createNativeView to createNativeView;
_initNativeView to initNativeView
_disposeNativeView to disposeNativeView
_resetNativeView to resetNativeView
Resolving comments
84e726e
Disable recycling of native views
e6250e7 
createNativeView will set iOS nativeView if it is null/undefined
hshristov force-pushed the hhristov/recycle-native-view-android branch from d2ace2f to e6250e7 Compare March 28, 2017 15:09

vchimev commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

widgets

vchimev commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

widgets-uitests-android

vchimev commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

widgets-uitests-ios

vchimev commented Mar 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@hshristov,

there are some failures for iOS that require to look into them.

vchimev merged commit 86b9be3 into master Mar 28, 2017
hshristov deleted the hhristov/recycle-native-view-android branch March 30, 2017 14:32

lock Bot commented Aug 27, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
vakrilov vakrilov approved these changes
vchimev vchimev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL