Binding to ViewBase as source now works - #4195
Merged
hshristov merged 2 commits intoMay 16, 2017
Merged
hshristov merged 2 commits into
hshristov merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vakrilov
suggested changes
May 15, 2017
Comment thread
tns-core-modules/ui/core/view-base/view-base.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| export class Binding { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Cant this be in a separate file.
view-base.ts is >1500 lines after this commit
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
It was in different file but using instanceof will make it cyclic reference.
Sorry, something went wrong.
hshristov
force-pushed
the
hhristov/fix-4127
branch
from
de442a8 to
3e35a74
Compare
May 16, 2017 07:56
vakrilov
approved these changes
May 16, 2017
Copy link
Copy Markdown
Contributor
Author
|
run ci |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4127