FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ability to load local files in a WebView on iOS devices by EddyVerbruggen · Pull Request #4444 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Ability to load local files in a WebView on iOS devices - #4444

Merged
vakrilov merged 2 commits into
NativeScript:masterfrom
EddyVerbruggen:ios-webview-load-local-url-fix
Jun 28, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Ability to load local files in a WebView on iOS devices#4444
vakrilov merged 2 commits into
NativeScript:masterfrom
EddyVerbruggen:ios-webview-load-local-url-fix

Conversation

EddyVerbruggen commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

Fixes #4443, unittest added.

EddyVerbruggen mentioned this pull request Jun 22, 2017
Closed
vakrilov suggested changes Jun 27, 2017
View reviewed changes

vakrilov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Can you please remove the maked comments. They are used to generate code snippets for the docs. However there is already a snippet called webview-localfile in this file - no need for another.

Comment thread tests/app/ui/web-view/web-view-tests.ts Outdated
public testLoadLocalFileWithSpaceInPath(done) {
let webView = this.testView;

// >> webview-localfile

vakrilov Jun 27, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove this comment

Comment thread tests/app/ui/web-view/web-view-tests.ts Outdated

// >> webview-localfile
webView.on(webViewModule.WebView.loadFinishedEvent, function (args: webViewModule.LoadEventData) {
// >> (hide)

vakrilov Jun 27, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove this comment

Comment thread tests/app/ui/web-view/web-view-tests.ts Outdated
catch (e) {
done(e);
}
// << (hide)

vakrilov Jun 27, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove this comment

Comment thread tests/app/ui/web-view/web-view-tests.ts Outdated
}
});
webView.src = "~/ui/web-view/test with spaces.html";
// << webview-localfile

vakrilov Jun 27, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove this comment

vakrilov commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

10x @EddyVerbruggen!
Can you please the unneeded comments and we can merge this one.

EddyVerbruggen commented Jun 27, 2017

Copy link
Copy Markdown
Contributor Author

Thanks! The comments are gone now, good to learn what those are used for 👍

vakrilov merged commit f399f6c into NativeScript:master Jun 28, 2017
EddyVerbruggen deleted the ios-webview-load-local-url-fix branch June 28, 2017 08:36

lock Bot commented Aug 27, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't load local files in a WebView on iOS devices

3 participants

Back | FazBrowse Home | New Git URL