FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: typo on android utils, getPalleteColor to getPaletteColor by danielgek · Pull Request #4687 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix: typo on android utils, getPalleteColor to getPaletteColor - #4687

Merged
vakrilov merged 2 commits into
NativeScript:masterfrom
danielgek:fix-typo-on-utils-android
Aug 24, 2017
ConversationCommits (2)ChecksFiles changed
Merged

fix: typo on android utils, getPalleteColor to getPaletteColor#4687
vakrilov merged 2 commits into
NativeScript:masterfrom
danielgek:fix-typo-on-utils-android

Conversation

danielgek commented Aug 10, 2017

Copy link
Copy Markdown
Contributor

This pr Fixes #4647 .

ghost added the ♥ community PR label Aug 10, 2017
hshristov suggested changes Aug 17, 2017
View reviewed changes

hshristov left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Although I like the change this is a breaking change.
It would be safer if you leave the old method there just for compatibility and mark it as obsolete. Also in the Obsolete decorator and API help specify the newer method.

NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017
NativeScript deleted a comment from ns-bot Aug 17, 2017

danielgek commented Aug 21, 2017

Copy link
Copy Markdown
Contributor Author

@hshristov totally agree with letting the old method, but i don't know what you mean by "Also in the Obsolete decorator and API help specify the newer methods." can you point me an example ?

hshristov commented Aug 24, 2017

Copy link
Copy Markdown
Contributor

@danielgek We have @Deprecated TypeScript decorator but apparently you cannot pass arguments to it. So comment is also good enough :)

vakrilov commented Aug 24, 2017

Copy link
Copy Markdown
Contributor

@danielgek Thanks for the PR!

vakrilov merged commit 7b36461 into NativeScript:master Aug 24, 2017
ghost removed the ♥ community PR label Aug 24, 2017
danielgek deleted the fix-typo-on-utils-android branch August 24, 2017 09:21

lock Bot commented Aug 27, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
vakrilov vakrilov approved these changes
hshristov hshristov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

utils.ad.getPalleteColor should be named getPaletteColor

4 participants

Back | FazBrowse Home | New Git URL