FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Introduce background shorthand property by ADjenkov · Pull Request #5053 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Introduce background shorthand property - #5053

Merged
SvetoslavTsenov merged 4 commits into
masterfrom
djenkov/background-shorthand
Nov 15, 2017
ConversationCommits (4)ChecksFiles changed
Merged

Introduce background shorthand property#5053
SvetoslavTsenov merged 4 commits into
masterfrom
djenkov/background-shorthand

Conversation

ADjenkov commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

Fixes #2992

ghost assigned ADjenkov Nov 9, 2017
ghost added the in progress label Nov 9, 2017

ns-bot commented Nov 9, 2017

Copy link
Copy Markdown

Please sign CLA at http://www.nativescript.org/cla

ns-bot added the cla: no label Nov 9, 2017
PanayotCankov approved these changes Nov 9, 2017
View reviewed changes

PanayotCankov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very well done!

SvetoslavTsenov commented Nov 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@ADjenkov, there are few failing unit tests on Travis, could you please try them on your side
88 passing (438ms)
1 pending
2 failing

  1. css parser values background can parse " url(smiley.gif) no-repeat top 50% left 100% #00ff00":
    AssertionError: expected { Object (start, end, ...) } to deeply equal { Object (start, end, ...) }

    • expected - actual
      "value": {
      "color": 4278255360
      "image": "smiley.gif"
      "position": {
    •  "text": "top 50% left 100% "
 "x": {
   "align": "left"
   "offset": {
     "unit": "%"

    at Context. (unit-tests/css/parser.ts:35:28)

  2. css parser values background can parse " url(smiley.gif) no-repeat top 50% left 100% / 100px 100px #00ff00":
    AssertionError: expected { Object (start, end, ...) } to deeply equal { Object (start, end, ...) }

    • expected - actual
      "value": {
      "color": 4278255360
      "image": "smiley.gif"
      "position": {
    •  "text": "top 50% left 100% "
 "x": {
   "align": "left"
   "offset": {
     "unit": "%"

    at Context. (unit-tests/css/parser.ts:35:28)

ADjenkov commented Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

@SvetoslavTsenov Travis tests for parser are now modified and fixed.

hshristov reviewed Nov 10, 2017
View reviewed changes
Comment thread apps/app/ui-tests-app/css/background-shorthand.ts
{ name: "black hex color only", background: "#000000" },
{ name: "yellow hex color only", background: "#ffff00" },
{ name: "blue color only", background: "blue" },
{ name: "repeat image only", background: 'url("~/ui-tests-app/resources/images/icon.png")' },

hshristov Nov 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There is no repeat specified

ADjenkov Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I meant that: I'm only setting image here and it will be repeating since it's the default
With other words: There will be repeating image displayed

But it's really misleading. I'll change it

SvetoslavTsenov merged commit fc9a0b7 into master Nov 15, 2017
SvetoslavTsenov deleted the djenkov/background-shorthand branch November 15, 2017 12:07

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
PanayotCankov PanayotCankov approved these changes
hshristov hshristov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ADjenkov

Labels

cla: no in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CSS background shorthand property

5 participants

Back | FazBrowse Home | New Git URL