FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for frequent crashes in Frame package by DickSmith · Pull Request #5063 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Fix for frequent crashes in Frame package - #5063

Closed
DickSmith wants to merge 11 commits into
NativeScript:masterfrom
DickSmith:master
ConversationCommits (11)ChecksFiles changed
Closed

Fix for frequent crashes in Frame package#5063
DickSmith wants to merge 11 commits into
NativeScript:masterfrom
DickSmith:master

Conversation

DickSmith commented Nov 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

I am getting this reported thousands of times in my crash reporter, so thought I might add in the guards.

Exception com.tns.NativeScriptException: Calling js method run failed TypeError: Cannot read property 'resolvedPage' of undefined File: "file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js, line: 1, column: 1243970 StackTrace: Frame: function:'r._onNavigatingTo', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1116270 Frame: function:'r.performGoBack', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1115755 Frame: function:'r._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1115165 Frame: function:'t._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 376106 Frame: function:'r._processNavigationQueue', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1114465 Frame: function:'t.setCurrent', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 371558 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1685047 Frame: function:'e.invokeTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1249233 Frame: function:'f.runTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1244354 Frame: function:'invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1250212 Frame: function:'n', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1265993 Frame: function:'u', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 889243 Frame: function:'e.invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1248532 Frame: function:'f.runGuarded', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1243898 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1243515 Frame: function:'run', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 889328
com.tns.Runtime.callJSMethodNative (Runtime.java)
com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088)
com.tns.Runtime.callJSMethodImpl (Runtime.java:970)
com.tns.Runtime.callJSMethod (Runtime.java:957)
com.tns.Runtime.callJSMethod (Runtime.java:941)
com.tns.Runtime.callJSMethod (Runtime.java:933)
com.tns.gen.java.lang.Runnable.run (Runnable.java:10)
android.os.Handler.handleCallback (Handler.java:739)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:158)
android.app.ActivityThread.main (ActivityThread.java:7231)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1230)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1120)```

Fix for #4986
7229c75 
I am getting this reported thousands of times in my crash reporter, so thought I might add in the guards.

ns-bot commented Nov 12, 2017

Copy link
Copy Markdown

Can one of the admins verify this patch?

ghost added the ♥ community PR label Nov 12, 2017
NathanWalker reviewed Nov 12, 2017
View reviewed changes

NathanWalker left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is critical issue and has caused many crashers on iOS and Android with NativeScript for Angular stack. In general more guards like this would help prevent unnecessary app crashers for everyone.

Thank you @DickSmith for posting this fix. @vakrilov @vchimev would be excellent to see this in on next builds soon 👍

Dick Smith added 3 commits November 12, 2017 22:45
After fixing the previous locally and repacking and releasing a new v…
452e452 
…ersion to my users, I also noticed a few of these as well:

```
com.tns.NativeScriptException: Calling js method run failed
TypeError: Cannot read property 'navDepth' of undefined
File: "file:///data/data/__REDACTED__/files/app/vendor.js, line: 1, column: 1281638
StackTrace:
Frame: function:'t._goBackCore', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 451275
Frame: function:'r.performGoBack', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1165482
Frame: function:'r._processNavigationContext', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1164863
Frame: function:'t._processNavigationContext', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 454543
Frame: function:'r._processNavigationQueue', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1164163
Frame: function:'t.setCurrent', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 449995
Frame: function:'', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1739072
Frame: function:'e.invokeTask', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1286901
Frame: function:'f.runTask', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1282022
Frame: function:'invoke', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1287880
Frame: function:'n', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1303661
Frame: function:'u', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 905520
Frame: function:'e.invoke', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1286200
Frame: function:'f.runGuarded', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1281566
Frame: function:'', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1281183
Frame: function:'run', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 905605
```
Formatting
79f0f55
Fixes for a low incidence but still possible crash on these:
389e4f2 
Exception com.tns.NativeScriptException: Calling js method run failed Error: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1438) android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1456) android.app.BackStackRecord.commitInternal(BackStackRecord.java:707) android.app.BackStackRecord.commit(BackStackRecord.java:671) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1088) com.tns.Runtime.callJSMethodImpl(Runtime.java:970) com.tns.Runtime.callJSMethod(Runtime.java:957) com.tns.Runtime.callJSMethod(Runtime.java:941) com.tns.Runtime.callJSMethod(Runtime.java:933) [REDACTED_DOMAIN_NAME](Runnable.java:10) android.os.Handler.handleCallback(Handler.java:751) android.os.Handler.dispatchMessage(Handler.java:95) android.os.Looper.loop(Looper.java:154) android.app.ActivityThread.main(ActivityThread.java:6692) java.lang.reflect.Method.invoke(Native Method) com.android.internal.os.ZygoteInit$[REDACTED_DOMAIN_NAME](ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358) File: "file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js, line: 1, column: 1284818 StackTrace: Frame: function:'t._navigateCore', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 451777 Frame: function:'r.performNavigation', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168391 Frame: function:'r._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168070 Frame: function:'t._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 455138 Frame: function:'r._processNavigationQueue', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1167343 Frame: function:'t.setCurrent', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 450583 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1743837 Frame: function:'e.invokeTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290081 Frame: function:'f.runTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1285202 Frame: function:'invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1291060 Frame: function:'n', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1306841 Frame: function:'u', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901375 Frame: function:'e.invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1289380 Frame: function:'f.runGuarded', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284746 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284363 Frame: function:'run', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901460
com.tns.Runtime.callJSMethodNative (Runtime.java)
com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088)
com.tns.Runtime.callJSMethodImpl (Runtime.java:970)
com.tns.Runtime.callJSMethod (Runtime.java:957)
com.tns.Runtime.callJSMethod (Runtime.java:941)
com.tns.Runtime.callJSMethod (Runtime.java:933)
com.tns.gen.java.lang.Runnable.run (Runnable.java:10)
android.os.Handler.handleCallback (Handler.java:751)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:154)
android.app.ActivityThread.main (ActivityThread.java:6692)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)
arrow_drop_down
Caused by java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
android.app.FragmentManagerImpl.checkStateLoss (FragmentManager.java:1438)
android.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:1456)
android.app.BackStackRecord.commitInternal (BackStackRecord.java:707)
android.app.BackStackRecord.commit (BackStackRecord.java:671)
com.tns.Runtime.callJSMethodNative (Runtime.java)
com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088)
com.tns.Runtime.callJSMethodImpl (Runtime.java:970)
com.tns.Runtime.callJSMethod (Runtime.java:957)
com.tns.Runtime.callJSMethod (Runtime.java:941)
com.tns.Runtime.callJSMethod (Runtime.java:933)
com.tns.gen.java.lang.Runnable.run (Runnable.java:10)
android.os.Handler.handleCallback (Handler.java:751)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:154)
android.app.ActivityThread.main (ActivityThread.java:6692)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)

=======================================================================================================================
=======================================================================================================================
=======================================================================================================================

Exception com.tns.NativeScriptException: Calling js method run failed Error: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1438) android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1456) android.app.BackStackRecord.commitInternal(BackStackRecord.java:707) android.app.BackStackRecord.commit(BackStackRecord.java:671) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1088) com.tns.Runtime.callJSMethodImpl(Runtime.java:970) com.tns.Runtime.callJSMethod(Runtime.java:957) com.tns.Runtime.callJSMethod(Runtime.java:941) com.tns.Runtime.callJSMethod(Runtime.java:933) [REDACTED_DOMAIN_NAME](Runnable.java:10) android.os.Handler.handleCallback(Handler.java:751) android.os.Handler.dispatchMessage(Handler.java:95) android.os.Looper.loop(Looper.java:154) android.app.ActivityThread.main(ActivityThread.java:6692) java.lang.reflect.Method.invoke(Native Method) com.android.internal.os.ZygoteInit$[REDACTED_DOMAIN_NAME](ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358) File: "file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js, line: 1, column: 1284818 StackTrace: Frame: function:'t._goBackCore', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 452207 Frame: function:'r.performGoBack', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168662 Frame: function:'r._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168043 Frame: function:'t._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 455138 Frame: function:'r._processNavigationQueue', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1167343 Frame: function:'t.setCurrent', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 450583 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1743837 Frame: function:'e.invokeTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290081 Frame: function:'f.runTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1285202 Frame: function:'invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1291060 Frame: function:'n', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1306841 Frame: function:'u', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901375 Frame: function:'e.invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1289380 Frame: function:'f.runGuarded', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284746 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284363 Frame: function:'run', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901460
com.tns.Runtime.callJSMethodNative (Runtime.java)
com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088)
com.tns.Runtime.callJSMethodImpl (Runtime.java:970)
com.tns.Runtime.callJSMethod (Runtime.java:957)
com.tns.Runtime.callJSMethod (Runtime.java:941)
com.tns.Runtime.callJSMethod (Runtime.java:933)
com.tns.gen.java.lang.Runnable.run (Runnable.java:10)
android.os.Handler.handleCallback (Handler.java:751)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:154)
android.app.ActivityThread.main (ActivityThread.java:6692)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)
arrow_drop_down
Caused by java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
android.app.FragmentManagerImpl.checkStateLoss (FragmentManager.java:1438)
android.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:1456)
android.app.BackStackRecord.commitInternal (BackStackRecord.java:707)
android.app.BackStackRecord.commit (BackStackRecord.java:671)
com.tns.Runtime.callJSMethodNative (Runtime.java)
com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088)
com.tns.Runtime.callJSMethodImpl (Runtime.java:970)
com.tns.Runtime.callJSMethod (Runtime.java:957)
com.tns.Runtime.callJSMethod (Runtime.java:941)
com.tns.Runtime.callJSMethod (Runtime.java:933)
com.tns.gen.java.lang.Runnable.run (Runnable.java:10)
android.os.Handler.handleCallback (Handler.java:751)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:154)
android.app.ActivityThread.main (ActivityThread.java:6692)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)
DickSmith changed the title Fix for #4986 Fix for frequent crashes in Frame package Nov 30, 2017
Dick Smith added 3 commits November 30, 2017 12:30
Fix for:
9fa0813 
```Exception com.tns.NativeScriptException: Calling js method run failed TypeError: Cannot read property 'getFragmentManager' of undefined File: "file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js, line: 1, column: 1290524 StackTrace: Frame: function:'t._goBackCore', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 452769 Frame: function:'r.performGoBack', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1174368 Frame: function:'r._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1173749 Frame: function:'t._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 456009 Frame: function:'r.goBack', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1172002 Frame: function:'t.back', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 589098 Frame: function:'e.back', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 471495 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 216780 Frame: function:'u', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 912894 Frame: function:'e.invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1295086 Frame: function:'f.runGuarded', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290452 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290069 Frame: function:'run', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 912979
com.tns.Runtime.callJSMethodNative (Runtime.java)
com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088)
com.tns.Runtime.callJSMethodImpl (Runtime.java:970)
com.tns.Runtime.callJSMethod (Runtime.java:957)
com.tns.Runtime.callJSMethod (Runtime.java:941)
com.tns.Runtime.callJSMethod (Runtime.java:933)
com.tns.gen.java.lang.Runnable.run (Runnable.java:10)
android.os.Handler.handleCallback (Handler.java:751)
android.os.Handler.dispatchMessage (Handler.java:95)
android.os.Looper.loop (Looper.java:154)
android.app.ActivityThread.main (ActivityThread.java:6692)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)```
Further safety checks based on previous fixes for Android as well as …
4c98d8e 
…hinted issues in iOS crash logs
Merge branch 'master' of github.com:NativeScript/NativeScript
c40b724
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from ns-bot Dec 4, 2017
NativeScript deleted a comment from vakrilov Dec 4, 2017
NativeScript deleted a comment from vakrilov Dec 4, 2017
vakrilov self-assigned this Dec 5, 2017

SvetoslavTsenov commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

testsappng

SvetoslavTsenov commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

uitests

SvetoslavTsenov commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

testsappng

Dick Smith added 3 commits December 8, 2017 00:07
Crashed: com.apple.main-thread
2d50158 
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000000deaddead
keyboard_arrow_up
arrow_right 0
NativeScript
NativeScript::reportFatalErrorBeforeShutdown(JSC::ExecState*, JSC::Exception*, bool) + 1544
1
NativeScript
NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*) + 104
2
NativeScript
ffi_closure_SYSV_inner + 948
3
NativeScript
.Ldo_closure + 20
4
UIKit
-[UIGestureRecognizer _touchesEnded:withEvent:] + 168
5
UIKit
__55-[UIGestureEnvironment _updateGesturesForEvent:window:]_block_invoke + 708
6
UIKit
-[UIGestureEnvironment _deliverEvent:toGestureRecognizers:usingBlock:] + 240
7
UIKit
-[UIGestureEnvironment _updateGesturesForEvent:window:] + 276
8
UIKit
-[UIWindow sendEvent:] + 3180
9
UIKit
-[UIApplication sendEvent:] + 340
10
UIKit
__dispatchPreprocessedEventFromEventQueue + 2364
11
UIKit
__handleEventQueueInternal + 4760
12
UIKit
__handleHIDEventFetcherDrain + 152
13
CoreFoundation
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24
Revert "Crashed: com.apple.main-thread"
c6ef60e 
This reverts commit 2d50158.
Try Catching these
88c94ce

hshristov commented Dec 18, 2017

Copy link
Copy Markdown
Contributor

@NathanWalker This PR #5173 should resolve all issues with navigation and application suspend/resume. I'm closing this PR.

hshristov closed this Dec 18, 2017

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

NathanWalker NathanWalker left review comments

Assignees

vakrilov

Labels

cla: yes ♥ community PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL