FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "feat(animation): support animating width/height properties (W… by SvetoslavTsenov · Pull Request #5136 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Revert "feat(animation): support animating width/height properties (W… - #5136

Merged
vchimev merged 1 commit into
masterfrom
tsenov/revert-feat-animation
Dec 7, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Revert "feat(animation): support animating width/height properties (W…#5136
vchimev merged 1 commit into
masterfrom
tsenov/revert-feat-animation

Conversation

SvetoslavTsenov commented Dec 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverting PR: #4917 because of some glitches in animations:
IOS:
In the example "layout-stack-height" appears white line during the animation
demo_ios.mp4.zip

Android:
In the examples "animation-army-100" on each animation on the top left corner of the screen, appears a rectangle before the animation to be completed.

demo.mp4.zip

ghost assigned SvetoslavTsenov Dec 6, 2017
ghost added the in progress label Dec 6, 2017
ns-bot added the cla: yes label Dec 6, 2017

justindujardin commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

Did you skip the review? It kind of sucks, now I've got a reverted PR that could have been avoided. I'm pretty sure I commented on this stuff.

vchimev commented Dec 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@justindujardin,

We appreciate your contribution and definitely want it into our code base.

I am afraid that while being busy working on the next official release of NativeScript (version 3.4.0), we have not been able to devote the time and attention it deserves to your pull request.

Let us reopen it (reopen it yourself) and share our suggestions there.

A branch with the original changes has been created - animate-width-height.

vchimev merged commit 8973a6f into master Dec 7, 2017
vchimev deleted the tsenov/revert-feat-animation branch December 7, 2017 10:11
vchimev pushed a commit that referenced this pull request Dec 7, 2017
Revert "Revert "feat(animation): support animating width/height prope…
6ab01de 
…rties (WIP) (#4917)" (#5136)"

This reverts commit 8973a6f.

justindujardin commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

@vchimev @SvetoslavTsenov I totally understand, sorry for sounding critical. 👍

MartoYankov pushed a commit that referenced this pull request May 7, 2019
Revert "Revert "feat(animation): support animating width/height prope…
66d631e 
…rties (WIP) (#4917)" (#5136)"

This reverts commit 8973a6f.
VladimirAmiorkov pushed a commit that referenced this pull request Jun 6, 2019
Revert "Revert "feat(animation): support animating width/height prope…
cd96687 
…rties (WIP) (#4917)" (#5136)"

This reverts commit 8973a6f.

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
vchimev vchimev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

SvetoslavTsenov

Labels

cla: yes in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL