FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(animation): support animating width/height properties by vchimev · Pull Request #5147 · NativeScript/NativeScript · GitHub

feat(animation): support animating width/height properties - #5147

Merged
SvetoslavTsenov merged 6 commits into
masterfrom
animate-width-height
May 21, 2019
Merged

SvetoslavTsenov merged 6 commits into
masterfrom
animate-width-height

Conversation

vchimev commented Dec 7, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

Original PR #4917 by @justindujardin that implements #1764.

vchimev commented Mar 16, 2018

Copy link
Copy Markdown
Contributor Author

Hello All,

Great work on this pull-request!

Our main concerns with this implementation are related to performance. I am afraid that we have not had the time to measure and investigate it due to higher priority tasks. However, we are aware of its importance and wide demand, that is why we would like to invest further efforts and improve this feature as well as the animations at all.

This has not been scheduled for release yet. Currently, we are working on the 4.1 roadmap, so I hope we could get it there. Please follow the issue and this pull-request for any comments and updates.

vchimev removed their assignment May 29, 2018

Copy link
Copy Markdown

When are you planning on giving this Pull Request some daylight?

Copy link
Copy Markdown
Collaborator

@vchimev i have read through the PR and I dont really see anything that would impact performances if not using width or height in into animations. I understand you want to improve the whole animation system but in the meantime it would still be very useful to get that PR in.
And it would allow us not to use tricks like rxjs or tweenjs which might have worst performance consequences.

Jonarod commented Feb 21, 2019

Copy link
Copy Markdown

Hey !!
What is to be done for this to be released ???
I can see some UI tests were not successful, however seems like the page hosting details is down... so it is not possible to check where it fails.

@vchimev could you bring some details back ?

Also, I agree with @farfromrefug here, as of today we use funky workarounds like Tween.js to animate width and height, for what I understand from @justindujardin 's code is that it should not be worse than todays hacks... Maybe you could release that PR with some beta warnings like to use with caution - still in beta or whatever: the community will surely help to stabilize it.

I can totally understand concerns (plus I can't see why tests fail...) but the PR is over 1 year old now 😅

Thanks !!

Copy link
Copy Markdown

Hello! Thank you very much for your improvements to NativeScript. This feature is essential for many developers, could you implement it please? Would you have a planned date?

ghost added the in progress label May 7, 2019
cla-bot Bot removed the in progress label May 8, 2019
ghost added the in progress label May 8, 2019
NativeScript deleted a comment from cla-bot Bot May 8, 2019
NativeScript deleted a comment from cla-bot Bot May 8, 2019
NativeScript deleted a comment from cla-bot Bot May 8, 2019
cla-bot Bot removed the in progress label May 9, 2019
ghost added the in progress label May 9, 2019
NativeScript deleted a comment from cla-bot Bot May 9, 2019
cla-bot Bot removed the in progress label May 9, 2019
ghost added the in progress label May 9, 2019
NativeScript deleted a comment from cla-bot Bot May 9, 2019
cla-bot Bot removed the in progress label May 21, 2019
NativeScript deleted a comment from cla-bot Bot May 21, 2019
MartoYankov added e2e test needed docs needed Additional documentation on this issue/PR is needed labels May 21, 2019
SvetoslavTsenov merged commit e7c575e into master May 21, 2019
SvetoslavTsenov deleted the animate-width-height branch May 21, 2019 14:00

Copy link
Copy Markdown

Thanks @MartoYankov and @SvetoslavTsenov for this improvement! Looking forward to use it.

Copy link
Copy Markdown

Is this scheduled for future releases? I'm not able to use it in 5.4.3 and couldn't find more details elsewhere

Copy link
Copy Markdown
Contributor

@danielnitu Sorry for the late reply. This will be available in the 6.0 release.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs needed Additional documentation on this issue/PR is needed e2e test needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants


Back | FazBrowse Home | New Git URL