FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix: Line-height breaks line break mode (iOS) by hettiger · Pull Request #5251 · NativeScript/NativeScript · GitHub

/ NativeScript Public

Fix: Line-height breaks line break mode (iOS) - #5251

Closed
hettiger wants to merge 6 commits into
NativeScript:masterfrom
hettiger:patch-2
ConversationCommits (6)ChecksFiles changed
Closed

Fix: Line-height breaks line break mode (iOS)#5251
hettiger wants to merge 6 commits into
NativeScript:masterfrom
hettiger:patch-2

Conversation

hettiger commented Jan 10, 2018

Copy link
Copy Markdown
Contributor

When setting line-height using a stylesheet, line break mode will stop working.

Working line break mode:
https://play.nativescript.org/?template=play-ng&id=3HPeu8

Now adding a style to home.component.css:

Label {
    line-height: 1;
}

Results in broken line break mode:
https://play.nativescript.org/?template=play-ng&id=3HPeu8&v=5

My Pull Request fixes this behavior.

Hristo Hristov and others added 5 commits December 14, 2017 19:59
fix: multiple android navigation chashes (NativeScript#5173)
f6907be 
* Fixes multiple android navigation chashes

* Fix page.ios unloaded event when navigated to.

* calling loaded/unloaded from application suspend resume on the rootview
refactor(core webpack): enable more module aliases to work with webpa…
50380f8 
…ck (NativeScript#5177)

Currently only "main/main-page" and "./main/main-page.js" work. Enable
"./main/main-page" and "main/main-page.js". Note that "main/main-page.ts"
for TS will not work. It doesn't work without webpack too.
docs: add CHANGELOG for 3.4.0 (NativeScript#5195)
fa26ba3
chore: link waffle.io board from README (NativeScript#5239)
02dba02 
In order to make our working boards more visible, I'm adding links to the corresponding waffle.io boards in the Repositories section.
Fix: Line-height property breaks line break mode (iOS)
d922952

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

21 similar comments

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ghost added the ♥ community label Jan 10, 2018

ns-bot commented Jan 10, 2018

Copy link
Copy Markdown

Please sign CLA at http://www.nativescript.org/cla

ns-bot added the cla: no label Jan 10, 2018

ns-bot commented Jan 26, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

Merge remote-tracking branch 'tns/master' into patch-2
42df241 
# Conflicts:
#	README.md
#	tns-core-modules/application/application.ios.ts
#	tns-core-modules/ui/frame/fragment.transitions.android.ts
#	tns-core-modules/ui/frame/frame-common.ts
#	tns-core-modules/ui/frame/frame.android.ts
#	tns-core-modules/ui/frame/frame.ios.ts
#	tns-core-modules/ui/page/page.ios.ts

SvetoslavTsenov commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

uitests

SvetoslavTsenov commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

cuteness

SvetoslavTsenov commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

testsappng

hettiger commented Jan 29, 2018

Copy link
Copy Markdown
Contributor Author

@SvetoslavTsenov I see one of the checks failed. Can you provide further information or are you taking this over? A click on Details gives me an ERR_NAME_NOT_RESOLVED error. As far as I remember all checks passed before I updated my PR.

SvetoslavTsenov commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

Hey @hettiger, thank you for your contribution. All checks are fine but we still need some time to review the PR.

ns-bot commented Feb 1, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

hettiger commented Feb 23, 2018

Copy link
Copy Markdown
Contributor Author

@SvetoslavTsenov Sorry for me asking again but it's almost been a month since your last comment and theres still one pending check. Just a friendly reminder :-)

NativeScript deleted a comment from ns-bot Mar 14, 2018

manoldonev commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

test

manoldonev closed this Mar 15, 2018
ghost removed the ♥ community PR label Mar 15, 2018
manoldonev reopened this Mar 15, 2018
ghost assigned manoldonev Mar 15, 2018
ghost added the in progress label Mar 15, 2018

ns-bot commented Mar 15, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

2 similar comments

ns-bot commented Mar 15, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Mar 15, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

manoldonev commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

run ci

manoldonev mentioned this pull request Mar 15, 2018
Merged

manoldonev commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

@hettiger I had to cherry-pick your fix and open a new PR (your authorship of the contribution is intact) as after some recent CI changes on our side we had some infrastructure issues with running our CI automated tests on the original PR.

Sorry for this!

manoldonev closed this Mar 15, 2018
ghost removed the in progress label Mar 15, 2018

hettiger commented Mar 15, 2018

Copy link
Copy Markdown
Contributor Author

Thank you @manoldonev

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
manoldonev manoldonev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

manoldonev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL