FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 by manoldonev · Pull Request #5341 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 - #5341

Merged
manoldonev merged 1 commit into
masterfrom
mdonev/modal-navigation-event-fix
Feb 6, 2018
ConversationCommits (1)ChecksFiles changed
Merged

fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340#5341
manoldonev merged 1 commit into
masterfrom
mdonev/modal-navigation-event-fix

Conversation

manoldonev commented Jan 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

TODO: Error: Cannot pop a Frame which is not at the top of the navigation stack. in a scenario with root tabview when switching tabs whose tabitems contain Frames.

manoldonev self-assigned this Jan 26, 2018
ghost added the in progress label Jan 26, 2018

ns-bot commented Jan 26, 2018

Copy link
Copy Markdown

Please sign CLA at http://www.nativescript.org/cla

ns-bot added the cla: no label Jan 26, 2018
manoldonev changed the title fix-next: navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 Jan 26, 2018

ns-bot commented Jan 26, 2018

Copy link
Copy Markdown

CLA signature found, happy contributing!

ns-bot added cla: yes and removed cla: no labels Jan 26, 2018
manoldonev changed the title fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 [WIP] fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 Feb 5, 2018
manoldonev force-pushed the mdonev/modal-navigation-event-fix branch 2 times, most recently from dd1bc8a to 46390ba Compare February 5, 2018 16:17
manoldonev changed the title [WIP] fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 fix-next(modal): navigation events' workflow in modal dialog scenarios Fixes #5323 #5340 Feb 5, 2018

manoldonev commented Feb 5, 2018

Copy link
Copy Markdown
Contributor Author

Error while switching tabs (containing frames with pages) in a root tabview scenario is now fixed.

manoldonev commented Feb 5, 2018

Copy link
Copy Markdown
Contributor Author

test uitests cuteness testappng

manoldonev force-pushed the mdonev/modal-navigation-event-fix branch from 46390ba to b2e932a Compare February 6, 2018 10:03

SvetoslavTsenov commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

test uitests cuteness testappng sdk

SvetoslavTsenov commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

test android#pete/fix-console-logs

SvetoslavTsenov commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

test uitests cuteness testappng sdk

manoldonev merged commit 85dc75e into master Feb 6, 2018
ghost removed the in progress label Feb 6, 2018
manoldonev added this to the 4.0 milestone Feb 6, 2018
manoldonev deleted the mdonev/modal-navigation-event-fix branch February 9, 2018 15:47

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
MartoYankov MartoYankov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

manoldonev

Labels

cla: yes ns-next

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

Frame.topmost() unexpected behavior after closing modal dialog with frame inside Closing modal frame should not raise Page.NavigatingFrom event

4 participants

Back | FazBrowse Home | New Git URL