FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add option to set a different root view at run time by MartoYankov · Pull Request #5386 · NativeScript/NativeScript · GitHub

/ NativeScript Public

feat: add option to set a different root view at run time - #5386

Merged
vakrilov merged 7 commits into
masterfrom
myankov/set-root-view
Feb 9, 2018
ConversationCommits (7)ChecksFiles changed
Merged

feat: add option to set a different root view at run time#5386
vakrilov merged 7 commits into
masterfrom
myankov/set-root-view

Conversation

MartoYankov commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

Expose a method to open a new root view when your app is running. It will be useful for test apps and angular livesync.

MartoYankov self-assigned this Feb 5, 2018
MartoYankov requested a review from vakrilov February 5, 2018 12:13
ghost added the in progress label Feb 5, 2018
ns-bot added the cla: yes label Feb 5, 2018
MartoYankov force-pushed the myankov/set-root-view branch from 6ce0af8 to 1967911 Compare February 5, 2018 12:45
MartoYankov force-pushed the myankov/set-root-view branch from 1967911 to 363128c Compare February 5, 2018 13:26
MartoYankov requested a review from ADjenkov February 6, 2018 13:30

SvetoslavTsenov commented Feb 7, 2018

Copy link
Copy Markdown
Contributor

test cuteness uitests

SvetoslavTsenov commented Feb 7, 2018

Copy link
Copy Markdown
Contributor

Hey @MartoYankov, can you check this unittest please
http://nsbuild01.telerik.com:8080/build/job/integration-tests-stable-unittestapp-android-api23-emulator/1830/artifact/target/surefire-reports/html/index.html

hshristov commented Feb 7, 2018

Copy link
Copy Markdown
Contributor

There is root property on application.launch event args. If you attach listener to this event and then call frame.reloadPage method you will be able to set the rootView in the eventArgs.root.
And this changes will lose the root view once Activity is destroyed!

SvetoslavTsenov commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

test api25

SvetoslavTsenov commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

test api25 api27

vakrilov commented Feb 8, 2018

Copy link
Copy Markdown
Contributor

@hshristov
Can you elaborate a bit. I'm guessing you are talking about that we are no longer caching the rootView inside (<any>app).rootView?
Will getting the rootView with application.gettRootView() in frame.reloadPage resolve the issue?

ghost assigned vakrilov Feb 9, 2018

SvetoslavTsenov commented Feb 9, 2018

Copy link
Copy Markdown
Contributor

test

vakrilov merged commit b113b00 into master Feb 9, 2018
vakrilov deleted the myankov/set-root-view branch February 9, 2018 14:04
ghost removed the in progress label Feb 9, 2018
GulajavaMinistudio mentioned this pull request Feb 11, 2018
Merged

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

ADjenkov Awaiting requested review from ADjenkov
1 more reviewer
vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

MartoYankov

vakrilov

Labels

cla: yes ns-next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL