feat(builder): enable reading xml from bundle - #5668
Merged
MartoYankov merged 2 commits intoApr 17, 2018
Merged
MartoYankov merged 2 commits into
MartoYankov merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MartoYankov
force-pushed
the
myankov/xml-bundle
branch
from
3e00cf8 to
4cd42bc
Compare
April 12, 2018 15:15
MartoYankov
force-pushed
the
myankov/xml-bundle
branch
from
4cd42bc to
008aa52
Compare
April 12, 2018 15:55
Copy link
Copy Markdown
Contributor
Author
|
test branch_webpack#myankov/xml-bundle branch_testsappng |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
What test could we have on this? |
Sorry, something went wrong.
vchimev
approved these changes
Apr 17, 2018
sis0k0
pushed a commit
that referenced
this pull request
May 16, 2018
sis0k0
pushed a commit
that referenced
this pull request
May 18, 2018
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable building pages from xml bundled with webpack. Currently, we copy the xml files even though they are already bundled.