FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios-image-asset): getImageAsync() can retrieve assets stored remotely in iCloud by DickSmith · Pull Request #5705 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios-image-asset): getImageAsync() can retrieve assets stored remotely in iCloud - #5705

Merged
manoldonev merged 3 commits into
NativeScript:masterfrom
DickSmith:master
Apr 25, 2018
ConversationCommits (3)ChecksFiles changed
Merged

fix(ios-image-asset): getImageAsync() can retrieve assets stored remotely in iCloud#5705
manoldonev merged 3 commits into
NativeScript:masterfrom
DickSmith:master

Conversation

DickSmith commented Apr 19, 2018

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

getImageAsync() cannot retrieve assets stored remotely in iCloud

What is the new behavior?

getImageAsync() can retrieve assets stored remotely in iCloud

Fixes #5704 .

ns-bot commented Apr 19, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

2 similar comments

ns-bot commented Apr 19, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ns-bot commented Apr 19, 2018

Copy link
Copy Markdown

Can one of the admins verify this patch?

ghost added the ♥ community PR label Apr 19, 2018

ns-bot commented Apr 19, 2018

Copy link
Copy Markdown

Please sign CLA at http://www.nativescript.org/cla

ns-bot added the cla: no label Apr 19, 2018

manoldonev commented Apr 20, 2018

Copy link
Copy Markdown
Contributor

Hey @DickSmith - can you sign the CLA at http://www.nativescript.org/cla?
Also, can you update your commit message to follow the guidelines listed here

vakrilov commented Apr 23, 2018

Copy link
Copy Markdown
Contributor

Note: You can check the em-mail you should sign the CLA with in the info of your commit

DickSmith changed the title Fix for #5704 fix(ios-image-asset): #5704 Apr 23, 2018

ns-bot commented Apr 23, 2018

Copy link
Copy Markdown

CLA signature found, happy contributing!

ns-bot added cla: yes and removed cla: no labels Apr 23, 2018

DickSmith commented Apr 23, 2018

Copy link
Copy Markdown
Contributor Author

@manoldonev @vakrilov

Sorry about that, I forgot which email was tied to this commit. 😀

Also, I updated the Subject Header. I think it's correct now?

ghost assigned manoldonev Apr 25, 2018
ghost added in progress and removed ♥ community PR labels Apr 25, 2018
manoldonev changed the title fix(ios-image-asset): #5704 fix(ios-image-asset): getImageAsync() can retrieve assets stored remotely in iCloud Apr 25, 2018

manoldonev commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

test

manoldonev merged commit 9e3da8e into NativeScript:master Apr 25, 2018
ghost removed the in progress label Apr 25, 2018

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
manoldonev manoldonev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

manoldonev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iOS: getImageAsync() fails if PHAsset is in iCloud (remote)

4 participants

Back | FazBrowse Home | New Git URL