chore(modal): update d.ts for showModal(...) parameters - #5734
Merged
manoldonev merged 3 commits intoApr 25, 2018
Merged
manoldonev merged 3 commits into
manoldonev merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
manoldonev
force-pushed
the
mdonev/show-modal-dts
branch
from
2c3e974 to
1f30a72
Compare
April 24, 2018 15:02
5 tasks done
manoldonev
force-pushed
the
mdonev/show-modal-dts
branch
from
1f30a72 to
ba73566
Compare
April 25, 2018 08:52
MartoYankov
approved these changes
Apr 25, 2018
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems we released the new showModal(...) API with incomplete d.ts metadata. This causes a problem in the following scenario where at the moment an additional type checking is needed: NativeScript/nativescript-angular#1293