fix(ios-dialogs): unable to show dialog from modal view without a page - #5881
Merged
ADjenkov merged 2 commits intoMay 29, 2018
Merged
ADjenkov merged 2 commits into
ADjenkov merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tbozhikov
approved these changes
May 29, 2018
MartoYankov
reviewed
May 29, 2018
Comment thread
tns-core-modules/ui/dialogs/dialogs.ios.ts
Outdated
| view = currentPage.modal; | ||
|
|
||
| if (view.ios instanceof UIViewController) { | ||
| viewController = currentPage.modal.ios; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Shouldn't this be viewController = view.ios?
Sorry, something went wrong.
ADjenkov
force-pushed
the
djenkov/modal-dialogs
branch
from
78201dd to
e6245b1
Compare
May 29, 2018 13:49
MartoYankov
approved these changes
May 29, 2018
SvetoslavTsenov
pushed a commit
that referenced
this pull request
May 30, 2018
#5881) * fix(ios-dialogs): unable to show dialog from modal view * tests(modal-navigation): add test that opens dialog inside modal view
Copy link
Copy Markdown
|
Can you please describe how to fix it? I have a <Page> in my modal and dialogs.action() for example doesn't work on iOS. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5879
The original problem occurred in an Angular app (Plugins team teamplate), that displays some dialogs inside modal view, bacause we are no longer wrapping modal view inside a Page in nativescript-angular@next.
This could also happen in a non Angular application (modal view without <Page>)
The solution is to search up in the hierarchy for a parent with UIViewController on which we should present the dialog.
Added test in modal-navigation app that opens dialog from modal view (with and without wrapping modal view content in Page)