fix(android): NavigationButton was read as "Button" by screenreaders. - #5949
Merged
vakrilov merged 2 commits intoJun 14, 2018
Merged
vakrilov merged 2 commits into
vakrilov merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The navigation button for the vision-impaired users were always read as: "Button" by the TalkBack service on Android.
vakrilov
approved these changes
Jun 14, 2018
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the awesome contribution @m-abs! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigation button for the vision-impaired users were always read as:
"Button" by the TalkBack service on Android.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes #5948
BREAKING CHANGES:
None to my knowledge
[Describe the impact of the changes here.]
Sets navigation content description with the value of NavigationButton.text on android.
Adds a test.
Migration steps:
Not required but NavigationButton property text should be set for the benefit of the vision-impaired users.