fix(ios): safeAreaLayoutGuide fallback for iOS 10 cases - #5960
Merged
vakrilov merged 4 commits intoJun 20, 2018
Merged
vakrilov merged 4 commits into
vakrilov merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
5 tasks
Copy link
Copy Markdown
Contributor
Author
|
test |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
Author
|
test |
Sorry, something went wrong.
manoldonev
approved these changes
Jun 19, 2018
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Crash reported in #5899.
What is the new behavior?
A fallback mechanism to init a layout guide during the layoutView in iOS 10.
Normal execution should not go trough the fallback as the safeAreaLayoutGuide property should already have been initialized in updateConstraints called in viewWillLayoutSubviews of the controller before the layout. This fallback is for cases layoutView was called before updateConstraints (perhaps manually called).
CC @NathanWalker