feat: Pass NS app to the native app instead of presenting it over the root VC - #5967
Merged
tdermendjiev merged 9 commits intoJun 27, 2018
Merged
tdermendjiev merged 9 commits into
tdermendjiev merged 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…enting it over the rootViewController When NativeScript embedded app is created from the native one we check for whether the topmost UIViewController has NativeScriptEmbedder protocol (implemented in the iOS Runtime) method 'presentNativeScriptApp:'. If yes, we call it with the NS app viewcontroller as a parameter so the embedder has control over the NS app (where and how to present it etc.) For backwards compatibility we present the NS app on top of the topmost UIViewController as a fallback.
…:NativeScript/NativeScript into tdermendzhiev/pass-embedded-ns-to-native
tdermendjiev
added a commit
to NativeScript/ios-jsc
that referenced
this pull request
Jun 19, 2018
When embedding a NativeScript application, the native class, calling the NS runtime, should conform to NativeScriptEmbedder protocol in order get a reference to the NativeScript application viewcontroller. Related to NativeScript/NativeScript#5967
tdermendjiev
added a commit
to NativeScript/ios-jsc
that referenced
this pull request
Jun 19, 2018
When embedding a NativeScript application, the native class, calling the NS runtime, should conform to NativeScriptEmbedder protocol in order get a reference to the NativeScript application viewcontroller. Related to NativeScript/NativeScript#5967
tdermendjiev
added a commit
to NativeScript/ios-jsc
that referenced
this pull request
Jun 19, 2018
When embedding a NativeScript application, the native class, calling the NS runtime, should conform to NativeScriptEmbedder protocol in order get a reference to the NativeScript application viewcontroller. Related to NativeScript/NativeScript#5967
5 tasks
mbektchiev
approved these changes
Jun 20, 2018
Comment thread
tns-core-modules/application/application.ios.ts
Outdated
| } | ||
| } | ||
|
|
||
| public getTopmostViewController(rootViewController: UIViewController): UIViewController { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@vakrilov Do we need to add documentation about this new public function? It can be quite useful when dealing with UIViewControllers and I think that it's a good idea.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Yup - we can expose it.
I think it better to make it static (it doesn't really need this). You can put it in the ios namespace in the utils module and the documentation should go in [utils.d.ts[(https://github.com/NativeScript/NativeScript/blob/master/tns-core-modules/utils/utils.d.ts#L185)
Sorry, something went wrong.
…h if !rootController
vakrilov
approved these changes
Jun 25, 2018
vakrilov
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Add docs for getVisibleViewController pls.
Otherwise looks good.
Sorry, something went wrong.
Comment thread
tns-core-modules/utils/utils.d.ts
Outdated
| */ | ||
| export function getCurrentAppPath(): string; | ||
|
|
||
| export function getVisibleViewController(rootViewController: UIViewController): UIViewController; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Add JSDoc for getVisibleViewController
Sorry, something went wrong.
vakrilov
approved these changes
Jun 25, 2018
tdermendjiev
force-pushed
the
tdermendzhiev/pass-embedded-ns-to-native
branch
3 times, most recently
from
447c5ef to
187f9a1
Compare
June 25, 2018 14:53
NativeScriptEmbedder is responsive for communication between the NS and the native iOS app. His delegate will implement methods which we can call from javascript such as "presentNativeScriptApp:".
5 tasks
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When NativeScript embedded app is created from the native one we check for whether the topmost UIViewController has NativeScriptEmbedder protocol (implemented in the iOS Runtime) method 'presentNativeScriptApp:'. If yes, we call it with the NS app viewcontroller as a parameter so the embedder has control over the NS app (where and how to present it etc.) For backwards compatibility we present the NS app on top of the topmost UIViewController as a fallback.
PR Checklist
What is the current behavior?
Currently embedded app is always presented on top of the rootViewController.
What is the new behavior?
The embedder is now able to choose where to present the NS app (present, push, add as a child ViewController etc.) by implementing 'presentNativeScriptApp' method. Even when he does not implement it the NS app will present on top of the visible(topmost) viewcontroller instead of the root one (which may be hidden in some scenarios).