FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(action-bar): #5743 navController may be null by DickSmith · Pull Request #6029 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(action-bar): #5743 navController may be null #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsonevn merged 4 commits into from
Jul 10, 2018
Conversation 7 Commits 4 Checks 0 Files changed
Merged

fix(action-bar): #5743 navController may be null #6029

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c491533
fix(action-bar): #5743 navController may be null
DickSmith Jul 4, 2018
b326688
Adjusted per request
DickSmith Jul 5, 2018
30cec2d
Merge branch 'master' into issue-5743
Jul 5, 2018
8df983d
Merge branch 'master' into issue-5743
DickSmith Jul 9, 2018
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
9 changes: 7 additions & 2 deletions tns-core-modules/ui/action-bar/action-bar.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,12 @@ export class ActionBar extends ActionBarBase {
const viewController = (<UIViewController>page.ios);
const navigationItem: UINavigationItem = viewController.navigationItem;
const navController = <UINavigationController>viewController.navigationController;
const navigationBar = navController ? navController.navigationBar : null;

if (!navController) {
return;
}

const navigationBar = navController.navigationBar;
let previousController: UIViewController;

// Set Title
Expand Down Expand Up @@ -377,4 +382,4 @@ export class ActionBar extends ActionBarBase {
this.updateFlatness(navBar);
}
}
}
}
Back | FazBrowse Home | New Git URL