FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(iOS-gestures) touch delegate does not call base class touch methods by farfromrefug · Pull Request #6113 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(iOS-gestures) touch delegate does not call base class touch methods #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vakrilov merged 6 commits into from
Aug 2, 2018
Conversation 16 Commits 6 Checks 0 Files changed
Merged

fix(iOS-gestures) touch delegate does not call base class touch methods #6113

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23e3526
fix ios Touch gestures super methods not being called on nativeView
farfromrefug Jul 25, 2018
0d66e51
Merge branch 'master' into ios_touch_fix
Jul 30, 2018
2f8fa6e
use “this.view”
farfromrefug Jul 30, 2018
aafcd07
Merge branch 'ios_touch_fix' of github.com:Akylas/NativeScript into i…
farfromrefug Jul 30, 2018
0e2dfae
Merge branch 'master' into ios_touch_fix
Jul 31, 2018
b30cc3c
Merge branch 'master' into ios_touch_fix
Aug 1, 2018
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 4 additions & 0 deletions tns-core-modules/ui/gestures/gestures.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -353,18 +353,22 @@ class TouchGestureRecognizer extends UIGestureRecognizer {

touchesBeganWithEvent(touches: NSSet<any>, event: any): void {
this.executeCallback(TouchAction.down, touches, event);
this.view.touchesBeganWithEvent(touches, event);
}

touchesMovedWithEvent(touches: NSSet<any>, event: any): void {
this.executeCallback(TouchAction.move, touches, event);
this.view.touchesMovedWithEvent(touches, event);
}

touchesEndedWithEvent(touches: NSSet<any>, event: any): void {
this.executeCallback(TouchAction.up, touches, event);
this.view.touchesEndedWithEvent(touches, event);
}

touchesCancelledWithEvent(touches: NSSet<any>, event: any): void {
this.executeCallback(TouchAction.cancel, touches, event);
this.view.touchesCancelledWithEvent(touches, event);
}

private executeCallback(action: string, touches: NSSet<any>, event: any): void {
Expand Down
Back | FazBrowse Home | New Git URL