FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

5868 observable array reduce bug by rakeshgirase · Pull Request #6219 · NativeScript/NativeScript · GitHub

5868 observable array reduce bug - #6219

Merged
ADjenkov merged 2 commits into
NativeScript:masterfrom
rakeshgirase:5868-ObservableArray-Reduce-Bug
Aug 28, 2018
Merged

ADjenkov merged 2 commits into
NativeScript:masterfrom
rakeshgirase:5868-ObservableArray-Reduce-Bug

Conversation

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

ObservableArray reduce function fails when the InitialValue is not supplied. This PR is to fix that bug.

What is the new behavior?

The new behavior is a bug fix where is the InitialValue is not supplied then appropriate array delegate function will be called.

Fixes/Implements/Closes #[Issue Number].
#5868

ghost added the ♥ community PR label Aug 25, 2018
ADjenkov self-requested a review August 28, 2018 08:26

Copy link
Copy Markdown
Contributor

test

ADjenkov merged commit 97a7b7e into NativeScript:master Aug 28, 2018
ghost removed the ♥ community PR label Aug 28, 2018
vakrilov pushed a commit that referenced this pull request Sep 11, 2018
* 5868 ObservableArray Reduce Bug

* 5868 ObservableArray Reduce Bug
tslint fixes

lock Bot commented Oct 22, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL