fix(tab-view): Title and icon positioning - #6362
Merged
vakrilov merged 3 commits intoOct 8, 2018
Merged
vakrilov merged 3 commits into
vakrilov merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MartoYankov
reviewed
Oct 5, 2018
Comment thread
tns-core-modules/ui/tab-view/tab-view.ios.ts
Outdated
| const orientation = controller.interfaceOrientation; | ||
| const isPortrait = orientation !== UIInterfaceOrientation.LandscapeLeft && orientation !== UIInterfaceOrientation.LandscapeRight; | ||
| const isIconAboveTitle = (majorVersion < 11) || (isPhone && isPortrait); | ||
| console.log(`UPDATING tabItem: ${tabItem.title} --- isPortrait:${isPortrait}, isPhone:${isPhone}, version: ${majorVersion}, isIconAboveTitle: ${isIconAboveTitle}`); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Remove the console.log or do it as a trace?
Sorry, something went wrong.
MartoYankov
reviewed
Oct 5, 2018
Comment thread
tns-core-modules/ui/tab-view/tab-view.ios.ts
MartoYankov
approved these changes
Oct 5, 2018
Copy link
Copy Markdown
Contributor
Author
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Hi, this issue is still in progress? I'm working with TabView in iOS and the problem is still present... I'm checking the different NS repository and the bug was reported a long time ago, any help I can give?? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
It will be best to open a new issue about it (with repro and screenshot) as it might be a different issue. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By guidelines TabViewItems usually have icon and title and IOS positions them correctly: either side-by-side or icon above the title depending on form factor, IOS version and orientation.
Here is how icon/text are positioned in different IOS version/device/orientation combinations:
In the icon above title cases, when only one of them (icon or title), IOS leaves space for the other. That why we have to either move the title a bit up or the icon a bit down so that it is vertically centered.
In IOS version before 11, the icon is always above the title so we did the adjustment every time. However, in 11 icon is above title only for phones in portrait mode. This fix handles this case.
There is a test page in the ui-test-app -> tab-view-icon-title-placement cc @SvetoslavTsenov
Fixes #3402