FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(application-settings): implemented allKeys method by surdu · Pull Request #6371 · NativeScript/NativeScript · GitHub

/ NativeScript Public

feat(application-settings): implemented allKeys method - #6371

Merged
vakrilov merged 4 commits into
NativeScript:masterfrom
surdu:all-keys
Oct 12, 2018
ConversationCommits (4)ChecksFiles changed
Merged

feat(application-settings): implemented allKeys method#6371
vakrilov merged 4 commits into
NativeScript:masterfrom
surdu:all-keys

Conversation

surdu commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

There is no way to get all key from application-settings.

What is the new behavior?

There is a method .allKeys() that returns all the keys from application-settings.

Fixes #6210.

ghost added the ♥ community PR label Oct 8, 2018
ns-bot added the cla: yes label Oct 8, 2018

vakrilov commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

Hey @surdu - Thanks for the PR!

vakrilov commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

test

surdu commented Oct 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@vakrilov Hey! My pleasure 😉

ghost assigned vakrilov Oct 9, 2018
ghost added in progress and removed ♥ community PR labels Oct 9, 2018

vakrilov commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

test

vakrilov merged commit 829d18b into NativeScript:master Oct 12, 2018
ghost removed the in progress label Oct 12, 2018
surdu deleted the all-keys branch October 12, 2018 12:23

radeva commented Nov 19, 2018

Copy link
Copy Markdown

Hi @surdu ,

Congratulations on being one of the winners in the {N} First-time contributors contest!

You can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: 
👉Your full name 
👉Your email 
👉Your country or residence 

Best regards,
The NativeScript Team

surdu commented Nov 19, 2018

Copy link
Copy Markdown
Contributor Author

O, wow! That's awesome! Thank you 😁

lock Bot commented Nov 19, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

vakrilov

Labels

cla: yes ♥ community PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

application-settings: access all keys

4 participants

Back | FazBrowse Home | New Git URL