FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix-next: restrict to safe area when transform by MartoYankov · Pull Request #6405 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix-next: restrict to safe area when transform - #6405

Merged
MartoYankov merged 1 commit into
masterfrom
myankov/safe-area-transform
Oct 15, 2018
ConversationCommits (1)ChecksFiles changed
Merged

fix-next: restrict to safe area when transform#6405
MartoYankov merged 1 commit into
masterfrom
myankov/safe-area-transform

Conversation

MartoYankov commented Oct 12, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Applying the safe area adjustments while there is a transform on the UIView leads to unexpected/undefined results. See warning in https://developer.apple.com/documentation/uikit/uiview/1622459-transform. This PR restricts the safe area logic when there is a transform set on the view. This should lead to the same behavior as 4.0.

An alternative would be to remove the transform, adjust the safe area, then re-apply the transform. Will check how this behaves.

Test with Groceries and NS-ng animations demo

ghost assigned MartoYankov Oct 12, 2018
ghost added the in progress label Oct 12, 2018

MartoYankov commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

test groceries_ios groceries_ios10 groceries_ios11 animations_ios animations_ios10 animations_ios11

MartoYankov commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

test --ignore ng_animation_examples_ios ng_animation_examples_ios10 ng_animation_examples_ios11

vakrilov commented Oct 15, 2018

Copy link
Copy Markdown
Contributor

The remove/adjust/re-apply approach will ultimately lead to better API as safe-area and transform will not alter each others behavior.
I think the solution in this PR is also viable as long as it is well documented, so "+1".

MartoYankov merged commit 7e891a9 into master Oct 15, 2018
ghost removed the in progress label Oct 15, 2018
MartoYankov deleted the myankov/safe-area-transform branch October 15, 2018 07:18

lock Bot commented Oct 15, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Oct 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
manoldonev manoldonev approved these changes
vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

MartoYankov

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL