FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(frame): back in parent frame when back states available by ADjenkov · Pull Request #6446 · NativeScript/NativeScript · GitHub

feat(frame): back in parent frame when back states available - #6446

Merged
MartoYankov merged 5 commits into
masterfrom
djenkov/extend-back
Oct 24, 2018
Merged

MartoYankov merged 5 commits into
masterfrom
djenkov/extend-back

Conversation

Copy link
Copy Markdown
Contributor
  • Navigate back in parent frame, if canGoBack in parent is true, when no back states available.
  • Set current frame as topmost after every back navigation
  • Unit test added

Note: required when nesting frames, since back in inner frame could lead to app exit even if there are previous pages on its parent frame.

ADjenkov self-assigned this Oct 23, 2018
ghost added the in progress label Oct 23, 2018
ADjenkov force-pushed the djenkov/extend-back branch from 7bc2645 to ad82f16 Compare October 23, 2018 13:10
MartoYankov merged commit af651d6 into master Oct 24, 2018
ghost removed the in progress label Oct 24, 2018
MartoYankov deleted the djenkov/extend-back branch October 24, 2018 07:18

lock Bot commented Oct 24, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL