Resolve incorrect name of listener when unsubscribing causing Views to be leaked in memory - #6487
Merged
VladimirAmiorkov merged 2 commits intoNov 2, 2018
Merged
VladimirAmiorkov merged 2 commits into
VladimirAmiorkov merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MartoYankov
approved these changes
Nov 2, 2018
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resurrection of the #6353 but it fixed the source rather than the effect that causes memory leak in NativeScript + Angular apps that use ListView or RadListView from nativescript-ui-listview plugin.
PR Checklist
What is the current behavior?
When using the Angular createEmbeddeedView from the ViewContainerRef, after calling clear() the created NativeScript Views are left in the memory
What is the new behavior?
When using the Angular createEmbeddeedView from the ViewContainerRef, after calling clear() the created NativeScript Views are collected by the GC and a no longer in the memory
Fixes/Implements/Closes #[Issue Number].
ProgressNS/nativescript-ui-feedback#825