FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios): native view frame optimizations in nested scenario by manoldonev · Pull Request #6809 · NativeScript/NativeScript · GitHub

fix(ios): native view frame optimizations in nested scenario - #6809

Merged
manoldonev merged 3 commits into
masterfrom
mdonev/ios-cachedframe-fix
Jan 23, 2019
Merged

manoldonev merged 3 commits into
masterfrom
mdonev/ios-cachedframe-fix

Conversation

manoldonev commented Jan 21, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

Setting native view frame optimizations were effectively disabled by changing the value of the cached frame and this was particularly visible in nested frame scenarios (resulting in multiple layout passes both top-down and bottom-up).

Fixes: #6728

manoldonev self-assigned this Jan 21, 2019
ghost added the in progress label Jan 21, 2019
manoldonev changed the title [DO NOT MERGE] fix(ios): native view frame optimizations in nested scenario fix(ios): native view frame optimizations in nested scenario Jan 22, 2019

Copy link
Copy Markdown
Contributor Author

test --ignore modal_navigation_ios#mdonev/ios-cachedframe-fix tsapps_ios ngapps_ios ios10 ios11 iosx

manoldonev merged commit 08acd84 into master Jan 23, 2019
manoldonev deleted the mdonev/ios-cachedframe-fix branch January 23, 2019 09:09
ghost removed the in progress label Jan 23, 2019

lock Bot commented Jan 24, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

navigation not working in nested frames & layout root scenario after parent navigation with slide transition

3 participants


Back | FazBrowse Home | New Git URL