feat(action-bar): flat mode breaks ios safe area - #6862
Merged
SvetoslavTsenov merged 1 commit intoFeb 6, 2019
Merged
SvetoslavTsenov merged 1 commit into
SvetoslavTsenov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MartoYankov
force-pushed
the
myankov/flat-action-bar
branch
from
dcb83c3 to
7b721e4
Compare
February 6, 2019 09:29
vakrilov
approved these changes
Feb 6, 2019
dtopuzov
added a commit
to NativeScript/functional-tests
that referenced
this pull request
Feb 6, 2019
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, when there is a flat action bar on a page, the safe area insets coming from parent views should be ignored.
Fixes #6788
Fixes #5855
@SvetoslavTsenov There are 10 new e2e test pages.