FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios): textview content clipped on every other newline by manoldonev · Pull Request #6864 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios): textview content clipped on every other newline #6864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SvetoslavTsenov merged 2 commits into from
Feb 6, 2019
Conversation 3 Commits 2 Checks 0 Files changed
Merged

fix(ios): textview content clipped on every other newline #6864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e13554e
fix(ios): textview content clipped on every other newline
manoldonev Feb 5, 2019
c922723
Merge branch 'master' into mdonev/no-scroll-animation-textview-ios-fix
SvetoslavTsenov Feb 6, 2019
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
12 changes: 11 additions & 1 deletion tns-core-modules/ui/text-view/text-view.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,16 @@ class UITextViewDelegateImpl extends NSObject implements UITextViewDelegate {
}
}

class NoScrollAnimationUITextView extends UITextView {
// see https://github.com/NativeScript/NativeScript/issues/6863
// UITextView internally scrolls the text you are currently typing to visible when newline character
// is typed but the scroll animation is not needed because at the same time we are expanding
// the textview (setting its frame)
public setContentOffsetAnimated(contentOffset: CGPoint, animated: boolean): void {
super.setContentOffsetAnimated(contentOffset, false);
}
}

@CSSType("TextView")
export class TextView extends EditableTextBase implements TextViewDefinition {
nativeViewProtected: UITextView;
Expand All @@ -103,7 +113,7 @@ export class TextView extends EditableTextBase implements TextViewDefinition {
public _isEditing: boolean;

createNativeView() {
const textView = UITextView.new();
const textView = NoScrollAnimationUITextView.new();
if (!textView.font) {
textView.font = UIFont.systemFontOfSize(12);
}
Expand Down
Back | FazBrowse Home | New Git URL