fix(css): widget properties in css didn't work - #6889
Merged
MartoYankov merged 1 commit intoFeb 13, 2019
Merged
MartoYankov merged 1 commit into
MartoYankov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test package_version#rc |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
|
test package_version#rc |
Sorry, something went wrong.
ADjenkov
approved these changes
Feb 13, 2019
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the docs - https://docs.nativescript.org/ui/styling#accessing-nativescript-component-properties-with-css - A developer can declare non-CSS widgets properties in the CSS and this would work if the properties accept text based value.
This works only for lowercase only properties, i.e. single word camel case, and it seems this never worked for multi-word camel case properties. The example in the docs works, but properties like textFieldBackgroundColor of the SearchBar didn't work. The solution to this bug is to allow the developer to declare such properties as kebab case like this text-field-background-color.
This actually implements a number of issues marked as features:
Fixes #5355
Fixes #5372
Fixes #6348
Docs needed:
https://docs.nativescript.org/angular/ui/styling#accessing-nativescript-component-properties-with-css