fix(android-animations): reuse animatorSet to prevent high memory usage - #6930
Merged
ADjenkov merged 1 commit intoFeb 21, 2019
Merged
ADjenkov merged 1 commit into
ADjenkov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test package_version#latest |
Sorry, something went wrong.
MartoYankov
reviewed
Feb 20, 2019
Comment thread
tns-core-modules/ui/animation/animation.android.ts
Outdated
Comment thread
tns-core-modules/ui/animation/animation.android.ts
Outdated
ADjenkov
force-pushed
the
djenkov/css-animations-leak
branch
from
de0c106 to
bb3b656
Compare
February 20, 2019 15:02
Copy link
Copy Markdown
Contributor
Author
|
test package_version#latest |
Sorry, something went wrong.
MartoYankov
approved these changes
Feb 20, 2019
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not recreate native animators when looping animation inside keyframe animation.
Android API > 23: Reusing animatorSet instead of recreating it on every animation iteration. This results in even less memory usage. Recreating it on every loop will lead to higher memory peaks (that will be collected a bit later by the GC)
Side note: pulse CSS animation consist multiple keyframes that animate the scale of an object to different values in a different times. New Animation is created for every keyframe in the keyframes rule. These animations (keyframes) will play sequentially and will repeat all together for specified iterations (or infinite). Every Animation (keyframe) has a AnimatorSet that holds multiple Animators depending on the number of properties it should animate. We do not want to recreate these Animators on every Animation (keyframe) replay.
Fix #5731