fix(android-bottom-tabs): transition type on programmatic selectedIndex change - #6942
Merged
manoldonev merged 2 commits intoFeb 22, 2019
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ttom tabs position
Copy link
Copy Markdown
|
Please sign CLA at http://www.nativescript.org/cla |
Sorry, something went wrong.
Copy link
Copy Markdown
|
CLA signature found, happy contributing! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Unfortunately, it is not clear for me how to implement tests which will test different transition scheme for top and bottom androidTabsPosition property. |
Sorry, something went wrong.
manoldonev
approved these changes
Feb 22, 2019
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently on programmatically change selectedIndex property always applied smoothly scroll to the new item (smoothScroll = true), even for TabView with bottom tabs position. Which lead to unnecessary tabs layout render, because if TabView has for example 3 tabs, and from tab3 you programmatically move to tab1 then tab2 also render.
What is the new behavior?
For TabView with bottom tabs position use immediately transition (smoothScroll = false) on programmatically change selectedIndex property.
It makes perfect sense with already disable the swipe navigation and the items preloading functionality.
Difference visualisation (with animated gif)