fix(ios-webview): report hostname lookup errors in loadFinished event - #6988
Merged
manoldonev merged 3 commits intoMar 18, 2019
Merged
manoldonev merged 3 commits into
manoldonev merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fixes NativeScript#6987 Certain types of WKWebView errors (including hostname resolution failures) are reported to webViewDidFailProvisionalNavigationWithError. The delegate needs to implement this function for applications to detect and react to these types of errors.
manoldonev
approved these changes
Mar 15, 2019
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
m-abs
added a commit
to m-abs/nativescript-webview-ext
that referenced
this pull request
Mar 15, 2019
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain types of WKWebView errors (including hostname resolution failures) are reported to webViewDidFailProvisionalNavigationWithError. The delegate needs to implement this function for applications to detect and react to these types of errors.
PR Checklist
What is the current behavior?
On iOS, the loadFinished event is never emitted if the hostname in the URL can't be found.
What is the new behavior?
loadFinished is emitted with the error property set on the event object when a hostname lookup error occurs. This is in line with what the documentation suggests should occur, and the behavior on Android.
Fixes #6987.