FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios): flat action bar incorrect layout after navigation by MartoYankov · Pull Request #7077 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios): flat action bar incorrect layout after navigation #7077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartoYankov merged 2 commits into from
Mar 29, 2019
Conversation 2 Commits 2 Checks 0 Files changed
Merged

fix(ios): flat action bar incorrect layout after navigation #7077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d15781
fix(action-bar): incorrect layout after navigation
MartoYankov Mar 26, 2019
28b5309
set extended layout for opaque bars earlier
MartoYankov Mar 27, 2019
File filter

Filter by extension

Filter by extension .ts  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
11 changes: 8 additions & 3 deletions tns-core-modules/ui/core/view/view.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,14 @@ export namespace ios {
return controller;
}

public viewDidLoad(): void {
super.viewDidLoad();

// Unify translucent and opaque bars layout
// this.edgesForExtendedLayout = UIRectEdgeBottom;
this.extendedLayoutIncludesOpaqueBars = true;
}

public viewWillLayoutSubviews(): void {
super.viewWillLayoutSubviews();
const owner = this.owner.get();
Expand Down Expand Up @@ -959,9 +967,6 @@ export namespace ios {
return;
}

// Unify translucent and opaque bars layout
this.extendedLayoutIncludesOpaqueBars = true;

updateAutoAdjustScrollInsets(this, owner);

if (!owner.parent) {
Expand Down
11 changes: 8 additions & 3 deletions tns-core-modules/ui/page/page.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,14 @@ class UIViewControllerImpl extends UIViewController {
return controller;
}

public viewDidLoad(): void {
super.viewDidLoad();

// Unify translucent and opaque bars layout
// this.edgesForExtendedLayout = UIRectEdgeBottom;
this.extendedLayoutIncludesOpaqueBars = true;
}

public viewWillAppear(animated: boolean): void {
super.viewWillAppear(animated);
const owner = this._owner.get();
Expand Down Expand Up @@ -100,9 +108,6 @@ class UIViewControllerImpl extends UIViewController {
frame._updateActionBar(owner);
}

// Unify translucent and opaque bars layout
this.extendedLayoutIncludesOpaqueBars = true;

// Set autoAdjustScrollInsets in will appear - as early as possible
iosView.updateAutoAdjustScrollInsets(this, owner);

Expand Down
11 changes: 8 additions & 3 deletions tns-core-modules/ui/tab-view/tab-view.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ class UITabBarControllerImpl extends UITabBarController {
return handler;
}

public viewDidLoad(): void {
super.viewDidLoad();

// Unify translucent and opaque bars layout
// this.edgesForExtendedLayout = UIRectEdgeBottom;
this.extendedLayoutIncludesOpaqueBars = true;
}

@profile
public viewWillAppear(animated: boolean): void {
super.viewWillAppear(animated);
Expand All @@ -36,9 +44,6 @@ class UITabBarControllerImpl extends UITabBarController {
return;
}

// Unify translucent and opaque bars layout
this.extendedLayoutIncludesOpaqueBars = true;

iosView.updateAutoAdjustScrollInsets(this, owner);

if (!owner.parent) {
Expand Down
Back | FazBrowse Home | New Git URL