FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(hmr): preserve navigation history on applying changes by vchimev · Pull Request #7146 · NativeScript/NativeScript · GitHub

feat(hmr): preserve navigation history on applying changes - #7146

Merged
vchimev merged 28 commits into
masterfrom
hmr
Apr 23, 2019
Merged

vchimev merged 28 commits into
masterfrom
hmr

Conversation

vchimev commented Apr 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

On a markup/script change in modules at runtime execute navigation to the changed module and clear the application navigation history.

What is the new behavior?

On a markup/script change in modules at runtime replaces the current back stack entry and preserve the application navigation history.

Main Points

Handle updates on View level which allows:

  • preserving application state when not only Frame, but alsoTabView and SideDrawer (Any View successor) are application roots
  • applying changes per module

Detect updates on app root module.

Mind the replacing of backstack entry in the Frame's backstack history.

Implements #7145.

ghost assigned vchimev Apr 15, 2019
ghost added the in progress label Apr 15, 2019
cla-bot Bot added the cla: yes label Apr 15, 2019
vchimev changed the title feat(hmr): preserve navigation history on applying module changes at runtime feat(hmr): preserve navigation history on applying changes Apr 15, 2019
vchimev marked this pull request as ready for review April 17, 2019 02:33
Comment thread tns-core-modules/ui/frame/frame.ios.ts Outdated
Comment thread tns-core-modules/ui/frame/frame.ios.ts Outdated
Comment thread tns-core-modules/ui/page/page-common.ts Outdated
vchimev merged commit d35e14e into master Apr 23, 2019
vchimev deleted the hmr branch April 23, 2019 14:47
ghost removed the in progress label Apr 23, 2019

lock Bot commented Apr 25, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL