FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios-tabview): crash when setting tab text color by MartoYankov · Pull Request #7188 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios-tabview): crash when setting tab text color - #7188

Merged
MartoYankov merged 1 commit into
releasefrom
myankov/fix-tab-crash
May 7, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(ios-tabview): crash when setting tab text color#7188
MartoYankov merged 1 commit into
releasefrom
myankov/fix-tab-crash

Conversation

MartoYankov commented Apr 30, 2019

Copy link
Copy Markdown
Contributor

fixes #7166

MartoYankov self-assigned this Apr 30, 2019
cla-bot Bot added the cla: yes label Apr 30, 2019
ghost added the in progress label Apr 30, 2019
vchimev approved these changes Apr 30, 2019
View reviewed changes

vchimev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about adding the sample page to the tests app instead of ui-tests-app?

MartoYankov commented Apr 30, 2019

Copy link
Copy Markdown
Contributor Author

Tried it, but there isn't an easy way to get the tab text color to verify it natively.

MartoYankov commented Apr 30, 2019

Copy link
Copy Markdown
Contributor Author

test package_version#latest

dtopuzov commented May 2, 2019

Copy link
Copy Markdown
Contributor

test package_version#latest branch#release

MartoYankov commented May 7, 2019

Copy link
Copy Markdown
Contributor Author

test package_version#latest

1 similar comment

SvetoslavTsenov commented May 7, 2019

Copy link
Copy Markdown
Contributor

test package_version#latest

MartoYankov merged commit 77c45da into release May 7, 2019
MartoYankov deleted the myankov/fix-tab-crash branch May 7, 2019 10:17
ghost removed the in progress label May 7, 2019

lock Bot commented May 6, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

manoldonev Awaiting requested review from manoldonev
ADjenkov Awaiting requested review from ADjenkov
1 more reviewer
vchimev vchimev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

MartoYankov

Labels

cla: yes e2e test needed patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL