FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(android/button): possible incorrect button visual state by ycherniavskyi · Pull Request #7190 · NativeScript/NativeScript · GitHub

fix(android/button): possible incorrect button visual state - #7190

Merged
MartoYankov merged 2 commits into
NativeScript:masterfrom
ycherniavskyi:process-missed-cancel-touch-action-in-button-highlighted-handler
May 8, 2019
Merged

MartoYankov merged 2 commits into
NativeScript:masterfrom
ycherniavskyi:process-missed-cancel-touch-action-in-button-highlighted-handler

Conversation

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

Currently, a button placed in ListView item does not restore its visual state to normal on cancel touch action which occurs when button received down touch action and then ListView scroll.

What is the new behavior?

A button placed in ListView item restore its visual state to normal on cancel touch action.

Difference visualisation (with animated gif)

  • current version

  • fixed version

ghost added the ♥ community PR label May 1, 2019
cla-bot Bot added the cla: yes label May 1, 2019
ghost assigned MartoYankov May 7, 2019
ghost added in progress and removed ♥ community PR labels May 7, 2019

Copy link
Copy Markdown
Contributor

Test

MartoYankov merged commit 2a02360 into NativeScript:master May 8, 2019
ghost removed the in progress label May 8, 2019

lock Bot commented May 20, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL