| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Sorry, something went wrong.
|
The cla-bot has been summoned, and re-checked this pull request! |
Sorry, something went wrong.
|
test |
Sorry, something went wrong.
|
test |
Sorry, something went wrong.
|
Hi @mehulcs There are some failing unit tests in your PR currently. They are caused by the logic in the getColumn and getColumnSpan which select the value from one of the "synonym" over the other. Giving it a further thought - as long as there are 2 properties for one value (ex. col and column) there will always be a problem so syncing these properties with one another or having to choose which one is to use. I have another more simple and easy to maintain approach. Define the column and columnSpan properties as javascript properties with getters and setters that will just fallback to the original property: Object.defineProperty(View.prototype, "column", {
get(this: View): number { return this.col; },
set(this: View, value: number) { this.col = value; },
enumerable: true,
configurable: true
});
Object.defineProperty(View.prototype, "columnSpan", {
get(this: View): number { return this.colSpan; },
set(this: View, value: number) { this.colSpan = value; },
enumerable: true,
configurable: true
});
This way we won't have to deal with syncing issues. I've tested this approach in this branch(based on your initial PR) - it seems to work as expected. |
Sorry, something went wrong.
|
Thanks, @vakrilov @manoldonev |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What is the current behavior?
There is no column property synonym of col.
What is the new behavior?
Added new property column synonym for col.
Fixes/Implements/Closes #7295 .