FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios-actionbar): parent/child gesture recognition by manoldonev · Pull Request #7400 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios-actionbar): parent/child gesture recognition - #7400

Merged
manoldonev merged 3 commits into
masterfrom
mdonev/master-detail-fix
Jun 26, 2019
ConversationCommits (3)ChecksFiles changed
Merged

fix(ios-actionbar): parent/child gesture recognition#7400
manoldonev merged 3 commits into
masterfrom
mdonev/master-detail-fix

Conversation

manoldonev commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

Changes related to parent/child gesture recognition in iOS introduced with #7296 break an ActionBar usage scenario in all master/detail templates here:

    <ActionBar class="action-bar">
       ...

        <ActionItem ios.position="right" android.position="right">
            <Label text="Done" class="action-item" verticalAlignment="center" tap="onDoneButtonTap" 
                isEnabled="{{ car.isModelValid }}"
                isUserInteractionEnabled="{{ car.isModelValid }}" />
        </ActionItem>
    </ActionBar>

Where tap event is not raised for the ActionItem Label anymore.

manoldonev self-assigned this Jun 24, 2019
cla-bot Bot added the cla: yes label Jun 24, 2019
manoldonev mentioned this pull request Jun 24, 2019
Merged
5 tasks

MCurran16 commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

:(

manoldonev merged commit 8722075 into master Jun 26, 2019
manoldonev deleted the mdonev/master-detail-fix branch June 26, 2019 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

manoldonev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL