fix: restore TextField.textChange and Switch.checkedChange event syntax in xml - #7403
Merged
manoldonev merged 5 commits intoJun 27, 2019
Merged
manoldonev merged 5 commits into
manoldonev merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…pt into NathanaelA-missingEvent
This comment was marked as abuse.
…pt into NathanaelA-missingEvent
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@NathanaelA we'd really like to find a more general solution (probably in the builder module) but for the time being we decided to accept this change as I am not sure we'll be able to investigate this further within the NativeScript 6.0 release timeframe. |
Sorry, something went wrong.
manoldonev
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
<TextField textChange="someFunc"/>
SomeFunc does not fire. When NativeScript was upgraded to v3.0.0 somehow when the renaming the events from properyChange to textChange on the text editable fields; this event was not properly declared. This became a nasty breaking change for NS-Core apps, as there is then now no way to wire up the "change" events via xml anymore at all. This really becomes problematic with repeaters and listviews (i.e. anything that has templates that can repeat)
What is the FIXED behavior?
<TextField textChange="someFunc"/>
someFunc will now be wired up properly from the XML builder so that this event will properly fire. This fixes the regression in NS 3.0 that has causes a lot of issues for those who are using NS Core for the last couple versions of NS.
Fixes/Implements/Closes #[Issue Number].
#5835, #3971 NativeScript/nativescript-angular#79
I would really like to see this show up in v6.00 -- It was broke in 3.00 and we (ns-core) have limped along with some significantly CRAPPY work arounds -- its time to get it fixed... ;-)
Btw, I can also add checkedChange (i.e. Switch regressed) event to this PR or another if you prefer. It is another item that's even was regressed in v3.0 of NS.